From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Aug 2018, #02; Mon, 6)
Date: Mon, 6 Aug 2018 23:47:14 -0400 [thread overview]
Message-ID: <CAPig+cRoxiPUhXFA2vdZWh0iLfitFeN5CbUDduJuRZ0JGw=fvA@mail.gmail.com> (raw)
In-Reply-To: <xmqqtvo7m8c0.fsf@gitster-ct.c.googlers.com>
On Mon, Aug 6, 2018 at 6:36 PM Junio C Hamano <gitster@pobox.com> wrote:
> * pw/rebase-i-author-script-fix (2018-08-02) 2 commits
> - sequencer: fix quoting in write_author_script
> - sequencer: handle errors in read_author_ident()
> (this branch uses es/rebase-i-author-script-fix.)
>
> Recent "git rebase -i" update started to write bogusly formatted
> author-script, with a matching broken reading code. These are
> being fixed.
>
> Undecided.
> Is it the list consensus to favor this "with extra code, read the
> script written by bad writer" approach?
Phillip's original "effectively one-liner" backward compatibility[1]
seemed a reasonable compromise[2] between the choices of no backward
compatibility and heavyweight backward compatibility of his
re-roll[3]. His reference[4] to an earlier "one-liner" backward
compatibility solution given similar circumstances bolstered the case
for his original approach.
[1]: https://public-inbox.org/git/20180731111532.9358-3-phillip.wood@talktalk.net/
[2]: https://public-inbox.org/git/455fafb5-3c92-4348-0c2c-0a4ab62cf2ce@talktalk.net/
[3]: https://public-inbox.org/git/20180802112002.720-3-phillip.wood@talktalk.net/
[4]: https://public-inbox.org/git/c7b8629d-7b93-2fbf-6793-0d566e86a229@talktalk.net/
next prev parent reply other threads:[~2018-08-07 3:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 22:35 What's cooking in git.git (Aug 2018, #02; Mon, 6) Junio C Hamano
2018-08-07 3:47 ` Eric Sunshine [this message]
2018-08-07 6:30 ` Eric Sunshine
2018-08-07 6:21 ` Ævar Arnfjörð Bjarmason
2018-08-07 14:36 ` Junio C Hamano
2018-08-07 14:54 ` Junio C Hamano
2018-08-08 22:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cRoxiPUhXFA2vdZWh0iLfitFeN5CbUDduJuRZ0JGw=fvA@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).