From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Martin Ågren" <martin.agren@gmail.com>,
"Derrick Stolee" <dstolee@microsoft.com>,
"Git List" <git@vger.kernel.org>
Subject: Re: [PATCH 2/3] gc: fix handling of crontab magic markers
Date: Tue, 22 Dec 2020 22:50:52 -0500 [thread overview]
Message-ID: <CAPig+cRmatC0Q22XBBx-ouzNSn5uiarTes1tSehGZuBWucSt1g@mail.gmail.com> (raw)
In-Reply-To: <xmqqsg7xfoj9.fsf@gitster.c.googlers.com>
On Tue, Dec 22, 2020 at 5:47 PM Junio C Hamano <gitster@pobox.com> wrote:
> Martin Ågren <martin.agren@gmail.com> writes:
> > +test_expect_success 'stop preserves surrounding schedule' '
> > + echo "Crucial information!" >>cron.txt &&
> > + GIT_TEST_CRONTAB="test-tool crontab cron.txt" git maintenance stop &&
>
> 31345d55 (maintenance: extract platform-specific scheduling,
> 2020-11-24) in ds/maintenance-part-4 needs to adjust this
> exported variable for the tests to pass in 'seen'
>
> Is it just the matter of replacing it with
> GIT_TEST_MAINT_SCHEDULER="crontab:test-tool crontab ..."
> or is there more to it?
Yes, renaming GIT_TEST_CRONTAB to GIT_TEST_MAINT_SCHEDULER and
prepending "crontab:" to the value should be sufficient (per the
proposal by [1] and realization by [2]).
[1]: https://lore.kernel.org/git/X6+iJNYEbpQjHCb0@flurp.local/
[2]: https://lore.kernel.org/git/4807342b0019be29bb369ed3403a485f0ce9c15d.1605647598.git.gitgitgadget@gmail.com/
next prev parent reply other threads:[~2020-12-23 3:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 21:26 [PATCH 0/3] gc: fix handling of crontab magic markers Martin Ågren
2020-12-21 21:26 ` [PATCH 1/3] git-maintenance.txt: add missing word Martin Ågren
2020-12-21 21:26 ` [PATCH 2/3] gc: fix handling of crontab magic markers Martin Ågren
2020-12-22 22:45 ` Junio C Hamano
2020-12-22 23:22 ` Junio C Hamano
2020-12-23 3:50 ` Eric Sunshine [this message]
2020-12-23 10:06 ` Martin Ågren
2020-12-23 20:00 ` Junio C Hamano
2020-12-21 21:26 ` [PATCH 3/3] t7900-maintenance: test for " Martin Ågren
2020-12-21 21:54 ` [PATCH 0/3] gc: fix handling of crontab " Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cRmatC0Q22XBBx-ouzNSn5uiarTes1tSehGZuBWucSt1g@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).