From: Eric Sunshine <firstname.lastname@example.org> To: Junio C Hamano <email@example.com> Cc: Josh Soref <firstname.lastname@example.org>, Josh Soref via GitGitGadget <email@example.com>, Git List <firstname.lastname@example.org> Subject: Re: [PATCH v3] git-merge: rewrite already up to date message Date: Sun, 2 May 2021 03:14:32 -0400 [thread overview] Message-ID: <CAPig+cRm9yE9vpcms4rpPwJxd-C0MQ8n17tiyW8ufXwG=1UaTg@mail.gmail.com> (raw) In-Reply-To: <email@example.com> On Sun, May 2, 2021 at 2:26 AM Junio C Hamano <firstname.lastname@example.org> wrote: > Eric Sunshine <email@example.com> writes: > > I don't have a strong opinion between Co-authored-by: and Helped-by: > > in this case. Here's my sign-off if you want to retain Co-authored-by: > > > > Signed-off-by: Eric Sunshine <firstname.lastname@example.org> > > I am not in principle opposed to the idea of co-authored-by; for > this particular one, we historically have used Helped-by (i.e. a > reviewer offers "writing it this way is cleaner" suggestions on the > list and then gets credited on the next version), and it wasn't > clear to me if you consented to be a co-author of the patch. If the > party who were named as a co-author responded that it is OK, I would > be perfectly fine. It wasn't my intention to be co-author but I'm OK with the designation in this particular case since I did end up authoring all the code in the patch (aside from `void`), even if that authorship was by accident through the circumstance of reviewing the patch (but, as mentioned above, I can go either way with it).
next prev parent reply other threads:[~2021-05-02 7:14 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-18 18:33 [PATCH] git-merge: move space to between strings Josh Soref via GitGitGadget 2021-04-18 19:17 ` Junio C Hamano 2021-04-21 23:22 ` [PATCH v2] git-merge: move primary point before parenthetical Josh Soref via GitGitGadget 2021-04-21 23:46 ` Eric Sunshine 2021-04-22 0:55 ` [PATCH v3] git-merge: rewrite already up to date message Josh Soref via GitGitGadget 2021-04-22 3:41 ` Eric Sunshine 2021-04-28 4:04 ` Junio C Hamano 2021-04-29 7:52 ` Junio C Hamano 2021-05-02 1:51 ` Josh Soref 2021-05-02 2:15 ` Eric Sunshine 2021-05-02 2:39 ` Junio C Hamano 2021-05-02 6:26 ` Junio C Hamano 2021-05-02 7:14 ` Eric Sunshine [this message] 2021-05-02 5:14 ` [PATCH v4 0/2] normalize & fix merge "up to date" messages Eric Sunshine 2021-05-02 5:14 ` [PATCH v4 1/2] merge(s): apply consistent punctuation to " Eric Sunshine 2021-05-02 5:14 ` [PATCH v4 2/2] merge: fix swapped "up to date" message components Eric Sunshine 2021-05-03 5:21 ` Junio C Hamano 2021-05-03 5:50 ` Eric Sunshine 2021-05-03 6:28 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAPig+cRm9yE9vpcms4rpPwJxd-C0MQ8n17tiyW8ufXwG=1UaTg@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v3] git-merge: rewrite already up to date message' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).