From: Eric Sunshine <sunshine@sunshineco.com>
To: Carlo Arenas <carenas@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Christian Couder <christian.couder@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH 2/2] read-cache: use time_t instead of unsigned long
Date: Mon, 12 Nov 2018 03:42:37 -0500 [thread overview]
Message-ID: <CAPig+cRksYnDxTO9mbH-ieW=M24CuU+J42JxTfC8z8fdWZrJ6Q@mail.gmail.com> (raw)
In-Reply-To: <20181112084031.11769-3-carenas@gmail.com>
On Mon, Nov 12, 2018 at 3:41 AM Carlo Marcelo Arenas Belón
<carenas@gmail.com> wrote:
> b968372279 ("read-cache: unlink old sharedindex files", 2017-03-06)
> introduced get_shared_index_expire_date using unsigned long to track
> the modification times of a shared index.
>
> dddbad728c ("timestamp_t: a new data type for timestamps", 2017-04-26)
> shows why that might problematic so move to time_t instead.
s/might/& be/
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
next prev parent reply other threads:[~2018-11-12 8:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 8:40 [PATCH 0/2] avoid unsigned long for timestamps Carlo Marcelo Arenas Belón
2018-11-12 8:40 ` [PATCH 1/2] builtin/commit: use timestamp_t in parse_force_date Carlo Marcelo Arenas Belón
2018-11-12 8:40 ` [PATCH 2/2] read-cache: use time_t instead of unsigned long Carlo Marcelo Arenas Belón
2018-11-12 8:42 ` Eric Sunshine [this message]
2018-11-12 10:53 ` Junio C Hamano
2018-11-12 14:54 ` Johannes Schindelin
2018-11-12 15:03 ` Junio C Hamano
2018-11-13 7:40 ` Carlo Marcelo Arenas Belón
2018-11-13 8:49 ` Johannes Schindelin
2018-11-13 9:10 ` Carlo Arenas
2018-11-13 9:43 ` Junio C Hamano
2018-11-12 12:06 ` [PATCH 0/2] avoid unsigned long for timestamps Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cRksYnDxTO9mbH-ieW=M24CuU+J42JxTfC8z8fdWZrJ6Q@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=carenas@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).