From: Eric Sunshine <sunshine@sunshineco.com>
To: Todd Zullinger <tmz@pobox.com>
Cc: "Git List" <git@vger.kernel.org>,
"Luis Marsano" <luis.marsano@gmail.com>,
"Ted Zlatanov" <tzz@lifelogs.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [RFC PATCH v2 2/4] git-credential-netrc: minor whitespace cleanup in test script
Date: Wed, 13 Jun 2018 01:42:59 -0400 [thread overview]
Message-ID: <CAPig+cRcPD9vh1WMX7UkiD9R_A-DrybvOYwi3R8U2bskfOV_1w@mail.gmail.com> (raw)
In-Reply-To: <20180613031040.3109-3-tmz@pobox.com>
On Tue, Jun 12, 2018 at 11:10 PM, Todd Zullinger <tmz@pobox.com> wrote:
> Signed-off-by: Todd Zullinger <tmz@pobox.com>
> ---
> diff --git a/contrib/credential/netrc/t-git-credential-netrc.sh b/contrib/credential/netrc/t-git-credential-netrc.sh
> index 58191a62f8..c5661087fe 100755
> --- a/contrib/credential/netrc/t-git-credential-netrc.sh
> +++ b/contrib/credential/netrc/t-git-credential-netrc.sh
> @@ -17,15 +17,15 @@
> # set up test repository
>
> test_expect_success \
> - 'set up test repository' \
> - 'git config --add gpg.program test.git-config-gpg'
> + 'set up test repository' \
> + 'git config --add gpg.program test.git-config-gpg'
Since you're touching all the tests in this script anyhow, perhaps
modernize them so the title and opening quote of the test body are on
the same line as test_expect_success, and the closing body quote is on
a line of its own?
test_expect_sucess 'setup test repository' '
...test body...
'
I also changed "set up" to "setup" to follow existing practice.
(Not necessarily worth a re-roll.)
> # The external test will outputs its own plan
> test_external_has_tap=1
>
> test_external \
> - 'git-credential-netrc' \
> - perl "$TEST_DIRECTORY"/../contrib/credential/netrc/test.pl
> + 'git-credential-netrc' \
> + perl "$TEST_DIRECTORY"/../contrib/credential/netrc/test.pl
>
> test_done
> )
next prev parent reply other threads:[~2018-06-13 5:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 5:19 [RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements Todd Zullinger
2018-06-07 5:19 ` [RFC PATCH 1/2] git-credential-netrc: make "all" default target of Makefile Todd Zullinger
2018-06-07 5:19 ` [RFC PATCH 2/2] git-credential-netrc: use in-tree Git.pm for tests Todd Zullinger
2018-06-09 21:18 ` [RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements Luis Marsano
2018-06-10 2:28 ` Todd Zullinger
2018-06-10 8:36 ` Ævar Arnfjörð Bjarmason
2018-06-13 3:08 ` Todd Zullinger
2018-06-13 6:15 ` Luis Marsano
2018-06-13 7:48 ` [PATCH] git-credential-netrc: remove use of "autodie" Ævar Arnfjörð Bjarmason
2018-06-13 16:48 ` Junio C Hamano
2018-06-13 17:26 ` Todd Zullinger
2018-06-13 3:10 ` [RFC PATCH v2 0/4] contrib/credential/netrc Makefile & test improvements Todd Zullinger
2018-06-13 6:59 ` Luis Marsano
2018-06-13 3:10 ` [RFC PATCH v2 1/4] git-credential-netrc: make "all" default target of Makefile Todd Zullinger
2018-06-13 3:10 ` [RFC PATCH v2 2/4] git-credential-netrc: minor whitespace cleanup in test script Todd Zullinger
2018-06-13 5:42 ` Eric Sunshine [this message]
2018-06-13 17:21 ` Todd Zullinger
2018-06-13 17:43 ` Eric Sunshine
2018-06-13 3:10 ` [RFC PATCH v2 3/4] git-credential-netrc: use in-tree Git.pm for tests Todd Zullinger
2018-06-13 3:10 ` [RFC PATCH v2 4/4] git-credential-netrc: fix exit status when tests fail Todd Zullinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cRcPD9vh1WMX7UkiD9R_A-DrybvOYwi3R8U2bskfOV_1w@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=luis.marsano@gmail.com \
--cc=tmz@pobox.com \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).