git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH] gitk: use the 'reference' format for the commit reference
@ 2020-08-27 16:12 Beat Bolli
  2020-08-27 16:26 ` Eric Sunshine
  0 siblings, 1 reply; 3+ messages in thread
From: Beat Bolli @ 2020-08-27 16:12 UTC (permalink / raw)
  To: Paul Mackerras; +Cc: git, Beat Bolli

Since 1f0fc1db85 (pretty: implement 'reference' format, 2019-11-19) in
the main Git repository, there's an officially blessed format for commit
references. Update gitk to also use this format.

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
---
 gitk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gitk b/gitk
index da84e22..b26996c 100755
--- a/gitk
+++ b/gitk
@@ -9433,8 +9433,7 @@ proc mktaggo {} {
 proc copyreference {} {
     global rowmenuid autosellen
 
-    set format "%h (\"%s\", %ad)"
-    set cmd [list git show -s --pretty=format:$format --date=short]
+    set cmd [list git show -s --pretty=reference]
     if {$autosellen < 40} {
         lappend cmd --abbrev=$autosellen
     }
-- 
2.26.0.277.gb8618d28a9


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] gitk: use the 'reference' format for the commit reference
  2020-08-27 16:12 [PATCH] gitk: use the 'reference' format for the commit reference Beat Bolli
@ 2020-08-27 16:26 ` Eric Sunshine
  2020-08-27 20:35   ` Beat Bolli
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Sunshine @ 2020-08-27 16:26 UTC (permalink / raw)
  To: Beat Bolli; +Cc: Paul Mackerras, Git List

On Thu, Aug 27, 2020 at 12:19 PM Beat Bolli <dev+git@drbeat.li> wrote:
> Since 1f0fc1db85 (pretty: implement 'reference' format, 2019-11-19) in
> the main Git repository, there's an officially blessed format for commit
> references. Update gitk to also use this format.
>
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>

See this thread:
https://lore.kernel.org/git/da9321b1bd56aafd16c8dcb99d5d628b79e2244e.1576100147.git.liu.denton@gmail.com/T/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gitk: use the 'reference' format for the commit reference
  2020-08-27 16:26 ` Eric Sunshine
@ 2020-08-27 20:35   ` Beat Bolli
  0 siblings, 0 replies; 3+ messages in thread
From: Beat Bolli @ 2020-08-27 20:35 UTC (permalink / raw)
  To: Eric Sunshine; +Cc: Paul Mackerras, Git List

On 27.08.20 18:26, Eric Sunshine wrote:
> On Thu, Aug 27, 2020 at 12:19 PM Beat Bolli <dev+git@drbeat.li> wrote:
>> Since 1f0fc1db85 (pretty: implement 'reference' format, 2019-11-19) in
>> the main Git repository, there's an officially blessed format for commit
>> references. Update gitk to also use this format.
>>
>> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
> 
> See this thread:
> https://lore.kernel.org/git/da9321b1bd56aafd16c8dcb99d5d628b79e2244e.1576100147.git.liu.denton@gmail.com/T/

Ooops, my memory is lacking!

Please ignore the noise...

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-27 20:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-27 16:12 [PATCH] gitk: use the 'reference' format for the commit reference Beat Bolli
2020-08-27 16:26 ` Eric Sunshine
2020-08-27 20:35   ` Beat Bolli

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).