From: Eric Sunshine <sunshine@sunshineco.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Matthieu Moy <matthieu.moy@grenoble-inp.fr>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH/RFC 01/10] ref-filter: introduce a parsing function for each atom in valid_atom
Date: Mon, 23 Nov 2015 18:44:35 -0500 [thread overview]
Message-ID: <CAPig+cRYEmbsye78ESOLfmSi56sBFeKpaEkpGSEwF=qrLZWx8g@mail.gmail.com> (raw)
In-Reply-To: <1447271075-15364-2-git-send-email-Karthik.188@gmail.com>
On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
> Introduce a parsing function for each atom in valid_atom. Using this
> we can define special parsing functions for each of the atoms. Since
> we have a third field in valid_atom structure, we now fill out missing
> cmp_type values.
I don't get it. Why do you need to "fill out missing cmp_type values"
considering that you're never assigning the third field in this patch?
Are you planning on filling in the third field in a future patch?
> Signed-off-by: Karthik Nayak <Karthik.188@gmail.com>
> ---
> diff --git a/ref-filter.c b/ref-filter.c
> @@ -19,42 +19,43 @@ typedef enum { FIELD_STR, FIELD_ULONG, FIELD_TIME } cmp_type;
> static struct {
> const char *name;
> cmp_type cmp_type;
> + void (*parser)(struct used_atom *atom);
Compiler diagnostic:
warning: declaration of 'struct used_atom' will not be
visible outside of this function [-Wvisibility]
Indeed, it seems rather odd to introduce the new field in this patch
but never actually do anything with it. It's difficult to understand
the intention.
> } valid_atom[] = {
> - { "refname" },
> - { "objecttype" },
> + { "refname", FIELD_STR },
> + { "objecttype", FIELD_STR },
> { "objectsize", FIELD_ULONG },
> - { "objectname" },
> - { "tree" },
> - { "parent" },
> + { "objectname", FIELD_STR },
> + { "tree", FIELD_STR },
> + { "parent", FIELD_STR },
> { "numparent", FIELD_ULONG },
> - { "object" },
> - { "type" },
> - { "tag" },
> - { "author" },
> - { "authorname" },
> - { "authoremail" },
> + { "object", FIELD_STR },
> + { "type", FIELD_STR },
> + { "tag", FIELD_STR },
> + { "author", FIELD_STR },
> + { "authorname", FIELD_STR },
> + { "authoremail", FIELD_STR },
> { "authordate", FIELD_TIME },
> - { "committer" },
> - { "committername" },
> - { "committeremail" },
> + { "committer", FIELD_STR },
> + { "committername", FIELD_STR },
> + { "committeremail", FIELD_STR },
> { "committerdate", FIELD_TIME },
> - { "tagger" },
> - { "taggername" },
> - { "taggeremail" },
> + { "tagger", FIELD_STR },
> + { "taggername", FIELD_STR },
> + { "taggeremail", FIELD_STR },
> { "taggerdate", FIELD_TIME },
> - { "creator" },
> + { "creator", FIELD_STR },
> { "creatordate", FIELD_TIME },
> - { "subject" },
> - { "body" },
> - { "contents" },
> - { "upstream" },
> - { "push" },
> - { "symref" },
> - { "flag" },
> - { "HEAD" },
> - { "color" },
> - { "align" },
> - { "end" },
> + { "subject", FIELD_STR },
> + { "body", FIELD_STR },
> + { "contents", FIELD_STR },
> + { "upstream", FIELD_STR },
> + { "push", FIELD_STR },
> + { "symref", FIELD_STR },
> + { "flag", FIELD_STR },
> + { "HEAD", FIELD_STR },
> + { "color", FIELD_STR },
> + { "align", FIELD_STR },
> + { "end", FIELD_STR },
> };
>
> #define REF_FORMATTING_STATE_INIT { 0, NULL }
> --
> 2.6.2
next prev parent reply other threads:[~2015-11-23 23:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 19:44 [PATCH/RFC 00/10] ref-filter: use parsing functions Karthik Nayak
2015-11-11 19:44 ` [PATCH/RFC 01/10] ref-filter: introduce a parsing function for each atom in valid_atom Karthik Nayak
2015-11-23 23:44 ` Eric Sunshine [this message]
2015-11-25 12:10 ` Karthik Nayak
2015-11-25 19:41 ` Eric Sunshine
2015-11-26 18:01 ` Karthik Nayak
2015-12-11 22:18 ` Junio C Hamano
2015-12-12 16:05 ` Karthik Nayak
2015-11-11 19:44 ` [PATCH/RFC 02/10] ref-filter: introduce struct used_atom Karthik Nayak
2015-12-01 23:00 ` Eric Sunshine
2015-11-11 19:44 ` [PATCH/RFC 03/10] ref-fitler: bump match_atom() name to the top Karthik Nayak
2015-11-11 19:44 ` [PATCH/RFC 04/10] ref-filter: skip deref specifier in match_atom_name() Karthik Nayak
2015-12-01 23:11 ` Eric Sunshine
2015-12-03 6:34 ` Karthik Nayak
2015-11-11 19:44 ` [PATCH/RFC 05/10] ref-filter: introduce color_atom_parser() Karthik Nayak
2015-12-01 23:27 ` Eric Sunshine
2015-12-03 13:35 ` Karthik Nayak
2015-12-13 6:05 ` Eric Sunshine
2015-12-13 18:46 ` Karthik Nayak
2015-11-11 19:44 ` [PATCH/RFC 06/10] strbuf: introduce strbuf_split_str_without_term() Karthik Nayak
2015-12-02 8:04 ` Eric Sunshine
2015-12-03 18:12 ` Karthik Nayak
2015-12-11 22:31 ` Junio C Hamano
2015-12-12 16:04 ` Karthik Nayak
2015-11-11 19:44 ` [PATCH/RFC 07/10] ref-filter: introduce align_atom_parser() Karthik Nayak
2015-12-02 21:23 ` Eric Sunshine
2015-12-07 17:00 ` Karthik Nayak
2015-11-11 19:44 ` [PATCH/RFC 08/10] ref-filter: introduce remote_ref_atom_parser() Karthik Nayak
2015-12-13 0:53 ` Eric Sunshine
2015-12-13 6:02 ` Karthik Nayak
2015-12-13 6:15 ` Eric Sunshine
2015-12-13 8:32 ` Karthik Nayak
2015-12-13 8:45 ` Eric Sunshine
2015-12-13 8:53 ` Karthik Nayak
2015-11-11 19:44 ` [PATCH/RFC 09/10] ref-filter: introduce contents_atom_parser() Karthik Nayak
2015-12-13 3:10 ` Eric Sunshine
2015-12-13 4:41 ` Eric Sunshine
2015-12-13 19:36 ` Karthik Nayak
2015-12-13 19:33 ` Karthik Nayak
2015-11-24 21:48 ` [PATCH/RFC 00/10] ref-filter: use parsing functions Jeff King
2015-11-25 12:07 ` Karthik Nayak
2015-11-25 13:44 ` [PATCH/RFC 10/10] ref-filter: introduce objectname_atom_parser() Karthik Nayak
2015-12-13 4:49 ` Eric Sunshine
2015-12-13 19:40 ` Karthik Nayak
2015-12-11 22:49 ` [PATCH/RFC 00/10] ref-filter: use parsing functions Junio C Hamano
2015-12-13 5:40 ` Eric Sunshine
2015-12-13 9:31 ` Karthik Nayak
2015-12-13 21:55 ` Eric Sunshine
2015-12-16 14:45 ` Karthik Nayak
2015-12-14 19:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cRYEmbsye78ESOLfmSi56sBFeKpaEkpGSEwF=qrLZWx8g@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
--cc=matthieu.moy@grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).