* [PATCH] git-gui: Make push remote combobox full width
@ 2017-12-11 0:48 Peter Urbanec
2017-12-17 13:49 ` Peter Urbanec
0 siblings, 1 reply; 3+ messages in thread
From: Peter Urbanec @ 2017-12-11 0:48 UTC (permalink / raw)
To: git; +Cc: patthoyts, Peter Urbanec
When pushing changes, the Remote combobox for the Destination Repository
does not take all available space in the layout. With long remote names,
this causes the combobox to have truncated entries even though there is
room to display them.
Anchor the remote_m combobox to both left and right edges of the grid
cell and use the same padding as url_t for a consistent, dynamic layout.
Signed-off-by: Peter Urbanec <git.user@urbanec.net>
---
lib/transport.tcl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/transport.tcl b/lib/transport.tcl
index a1a424a..1046dc5 100644
--- a/lib/transport.tcl
+++ b/lib/transport.tcl
@@ -173,7 +173,7 @@ proc do_push_anywhere {} {
} else {
eval tk_optionMenu $w.dest.remote_m push_remote $all_remotes
}
- grid $w.dest.remote_r $w.dest.remote_m -sticky w
+ grid $w.dest.remote_r $w.dest.remote_m -sticky we -padx {0 5}
if {[lsearch -sorted -exact $all_remotes origin] != -1} {
set push_remote origin
} else {
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] git-gui: Make push remote combobox full width
2017-12-11 0:48 [PATCH] git-gui: Make push remote combobox full width Peter Urbanec
@ 2017-12-17 13:49 ` Peter Urbanec
2017-12-18 2:58 ` Eric Sunshine
0 siblings, 1 reply; 3+ messages in thread
From: Peter Urbanec @ 2017-12-17 13:49 UTC (permalink / raw)
To: git; +Cc: patthoyts, git.user
Just wondering if I submitted this patch correctly and to the right place.
On 11/12/17 11:48, Peter Urbanec wrote:
> When pushing changes, the Remote combobox for the Destination Repository
> does not take all available space in the layout. With long remote names,
> this causes the combobox to have truncated entries even though there is
> room to display them.
>
> Anchor the remote_m combobox to both left and right edges of the grid
> cell and use the same padding as url_t for a consistent, dynamic layout.
>
>
> Signed-off-by: Peter Urbanec <git.user@urbanec.net>
> ---
> lib/transport.tcl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/transport.tcl b/lib/transport.tcl
> index a1a424a..1046dc5 100644
> --- a/lib/transport.tcl
> +++ b/lib/transport.tcl
> @@ -173,7 +173,7 @@ proc do_push_anywhere {} {
> } else {
> eval tk_optionMenu $w.dest.remote_m push_remote $all_remotes
> }
> - grid $w.dest.remote_r $w.dest.remote_m -sticky w
> + grid $w.dest.remote_r $w.dest.remote_m -sticky we -padx {0 5}
> if {[lsearch -sorted -exact $all_remotes origin] != -1} {
> set push_remote origin
> } else {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] git-gui: Make push remote combobox full width
2017-12-17 13:49 ` Peter Urbanec
@ 2017-12-18 2:58 ` Eric Sunshine
0 siblings, 0 replies; 3+ messages in thread
From: Eric Sunshine @ 2017-12-18 2:58 UTC (permalink / raw)
To: Peter Urbanec; +Cc: Git List, Pat Thoyts
On Sun, Dec 17, 2017 at 8:49 AM, Peter Urbanec <git.user@urbanec.net> wrote:
> Just wondering if I submitted this patch correctly and to the right place.
You sent it to the right place. Unfortunately, Pat hasn't been around
much lately, so the git-gui project is apparently slumbering.
Junio has accepted a few patches for git-gui recently[1,2,3]; whether
he's interested in doing the same for your patch is unknown.
[1]: https://github.com/patthoyts/git-gui/pull/17
[2]: https://github.com/patthoyts/git-gui/pull/16
[3]: https://github.com/patthoyts/git-gui/pull/15
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-18 2:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-11 0:48 [PATCH] git-gui: Make push remote combobox full width Peter Urbanec
2017-12-17 13:49 ` Peter Urbanec
2017-12-18 2:58 ` Eric Sunshine
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).