From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 789441F953 for ; Wed, 29 Dec 2021 06:48:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239015AbhL2Gs5 (ORCPT ); Wed, 29 Dec 2021 01:48:57 -0500 Received: from mail-pg1-f179.google.com ([209.85.215.179]:43662 "EHLO mail-pg1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234572AbhL2Gs4 (ORCPT ); Wed, 29 Dec 2021 01:48:56 -0500 Received: by mail-pg1-f179.google.com with SMTP id 8so17769064pgc.10 for ; Tue, 28 Dec 2021 22:48:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yXHgLCDjdPyAsD/JFFff9VMh8TTt+o+l68kNdrBg5q0=; b=gIwW3ABJ7a3cKzvCwOFZJVJdp8/Cf8hir/DZF/hGHzphvaq/QrsZLgbmQu3kfWpkaR GuqlAoQH4H+AwDK9cKwzdD86iknaKoUZhTp8R+aJWvA0np/TCPgwbYgPJLloO1PZhJQS 04biDNNWcxP+rUnXlQB+/GLyCnW9XRu0a1+SUzRRz/7o2+w2dLSov+tJQgJ95PWnIJYt zJ8SgY96wb+vcABs4rLzq13Dn21rbs/bC8M0pM6n9JeIhUMSkrJnKhMP00IaDDPD2i+E J22AlpK7F4e4xjkhPVk6H3oxg1lEN/HBSO5jSPZcri+2Cy4HyDm9QQPPNNZV3zlJNmrx VCwg== X-Gm-Message-State: AOAM531ZzHNL84DP35ypuyoynSYmmwnEwdm/lWvKP75yhloKjBph26f1 M24ogZuvs30Aj90jid0wn510+qfqkHuoMnLPicE= X-Google-Smtp-Source: ABdhPJzbybxqO2InngLFEZs1YMayqsoDX8iYw3vMAyEbghQuU3QQlexpUw0nh25Q5x9r5CHpf3A0htzM7qpEpw8MH5E= X-Received: by 2002:a63:3e41:: with SMTP id l62mr17669621pga.139.1640760536400; Tue, 28 Dec 2021 22:48:56 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Eric Sunshine Date: Wed, 29 Dec 2021 01:48:45 -0500 Message-ID: Subject: Re: [PATCH v3 3/6] worktree: add 'init-worktree-config' subcommand To: Derrick Stolee via GitGitGadget Cc: Git List , Derrick Stolee , Sean Allred , Junio C Hamano , Elijah Newren , Derrick Stolee , Derrick Stolee Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Dec 28, 2021 at 4:32 PM Derrick Stolee via GitGitGadget wrote: > [...] > To help resolve this transition, create the 'git worktree > init-worktree-config' helper. This new subcommand does the following: > [...] Like my not-a-proper-review of [6/6], this also is not a proper review... > Signed-off-by: Derrick Stolee > --- > diff --git a/builtin/worktree.c b/builtin/worktree.c > @@ -1031,6 +1032,85 @@ static int repair(int ac, const char **av, const char *prefix) > +static int init_worktree_config(int ac, const char **av, const char *prefix) > +{ > + struct config_set cs = { 0 }; On macOS with "Apple LLVM version 10.0.0 (clang-1000.10.44.4)" and DEVELOPER=1, the above code breaks the build: builtin/worktree.c:1093:27: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] struct config_set cs = { 0 }; It wants extra braces in the initializer. This fixes it: struct config_set cs = { { 0 } };