From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 387681F403 for ; Thu, 6 Oct 2022 20:59:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232082AbiJFU7H (ORCPT ); Thu, 6 Oct 2022 16:59:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231796AbiJFU7F (ORCPT ); Thu, 6 Oct 2022 16:59:05 -0400 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADF43BBE12 for ; Thu, 6 Oct 2022 13:59:04 -0700 (PDT) Received: by mail-io1-f45.google.com with SMTP id l127so2238353iof.12 for ; Thu, 06 Oct 2022 13:59:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aUWF3fMD7uGQu4vIQZeUZtWjisxJHfY+GOqoT+UHQ18=; b=V4wl/Xb5jD5WRoXZwhlSiNI1tuosZXLvc+uNQN1I+HlLkk/tU24chLJXUBmgFC6Nna sE/z8lUdU/mXwnfBYQtQBUcSWuRz3Q41h7N6eRZVvknXbrwY5gVmtmsxtY2FTGr5euKR DkMRDLlJX3+3r7MuHkX+OnyYg/FAH+jUzl1hofCeEKb1q3YMemgp4EOHTAXZN2cNj0UU jL/JmrnjerZBG4qw6BIi23hpXSIrSA50eEAj3fHiDy8nO5vgP6HWD3Gqn5vJN8z6daz6 EXro5ewzKiTfuG1oiggv4qTxlw/wBTDMgFDrN5+2Mys4/Ro1FODPutNGNg5tX1NDFbTd Gxqw== X-Gm-Message-State: ACrzQf37eAxSWmJ3aWYuwHBpvnrNm2KTeI2Zu5AUKClq7bu1kyntMekl z8rHdwxSDToBEUvbzSEH1Z7j/vvpgQ42ycHLBG0= X-Google-Smtp-Source: AMsMyM5gOFR/MrRmnkozjSo5HlGO5Gsjj7Dod9TZXYv3KyFt9+2mHAzSPargUgh4NwHj24fCEQHxetYj8wF6yY52ll4= X-Received: by 2002:a05:6602:2c89:b0:67b:7e8c:11c1 with SMTP id i9-20020a0566022c8900b0067b7e8c11c1mr793006iow.101.1665089943950; Thu, 06 Oct 2022 13:59:03 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Eric Sunshine Date: Thu, 6 Oct 2022 16:58:53 -0400 Message-ID: Subject: Re: [PATCH 0/2] Fix syntax errors under clang 11.0.0 on MacOS To: Junio C Hamano Cc: Jeff Hostetler via GitGitGadget , git@vger.kernel.org, Jeff Hostetler Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Oct 6, 2022 at 4:41 PM Junio C Hamano wrote: > "Jeff Hostetler via GitGitGadget" writes: > > This patch series fixes three syntax errors that caused compiler errors with > > clang 11.0.0 on MacOS. I've included the error/warning messages in the > > commit messages. The offending statements did compile successfully under > > clang 14.0.0 on MacOS, so I have to assume that this usage is newer than > > what clang 11 supports. > > Ah, this looked familiar, and the last time we saw the one in > builtin/unpack-objects.c > > https://lore.kernel.org/git/20220710081135.74964-1-sunshine@sunshineco.com/ > > It seems that merge-file.c was OK back then but soon after we > "broke" it with 480a0e30 (merge-file: refactor for subsequent memory > leak fix, 2022-07-01). For completeness, the merge-file.c instance also got reported: https://lore.kernel.org/git/365e01e93dce582e9d926e83bdc6891310d22699.1659084832.git.congdanhqx@gmail.com/