From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 707751F5AE for ; Fri, 4 Jun 2021 18:03:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230443AbhFDSFP (ORCPT ); Fri, 4 Jun 2021 14:05:15 -0400 Received: from mail-ej1-f47.google.com ([209.85.218.47]:45019 "EHLO mail-ej1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbhFDSFO (ORCPT ); Fri, 4 Jun 2021 14:05:14 -0400 Received: by mail-ej1-f47.google.com with SMTP id c10so15756501eja.11 for ; Fri, 04 Jun 2021 11:03:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CBOjIWRgirw6hFudNqOWI8gMLfJU9r+Y2/kdGj5pL8M=; b=oTKVf2Zp8RQ/Fm9xOEr8Aw5wDmRNVYDCMu+zjJognW0yQQtGlxr05fuefaGaBTyFHM dreVDqfULz++YUtYjjmRGyTQueOIRTHCbfV+JzUAgGhfyv4FshtwFxJA8gFahELlG/ou 7rgk/15WX1LbqcTJLSEKPNfxh4nQzdCVNrktA9MoxnAUObUvngr30zilrvtJF3BWQ8Wf 3HV14/YFavyfo8Mtp2ZlYTQ0+suGLMDUsimTctrapCC+JZUpncoapLXs+10gdAj3hjJ/ ytM+02l3KRxNNp9F8NG4kBNbOc9Vk5hGZz4l6LiQEGL2y6Y1s+PUU+lCaPNx2XF1JAsK OX+g== X-Gm-Message-State: AOAM531e7wjl9tUI89ar7V9fS7DgJOGbiV2FkGTiZMAZt1XyuHwklPJa OBCWaUmyH0Qk5q6x6SPWt46+csC5FTRQ6jnc7F4= X-Google-Smtp-Source: ABdhPJwi4zOJecqPdvl77MNAX3jIVxUsqq7THOl/4GJ7Nao6c3tGjBg/cBaS0BkJL0ITdmBREA+a2AXG6ylpazUk8p4= X-Received: by 2002:a17:906:c311:: with SMTP id s17mr5287023ejz.202.1622829807351; Fri, 04 Jun 2021 11:03:27 -0700 (PDT) MIME-Version: 1.0 References: <3170f78daa5fa89f04f61e24c9c64c93ea5b394f.1622828605.git.gitgitgadget@gmail.com> In-Reply-To: <3170f78daa5fa89f04f61e24c9c64c93ea5b394f.1622828605.git.gitgitgadget@gmail.com> From: Eric Sunshine Date: Fri, 4 Jun 2021 14:03:16 -0400 Message-ID: Subject: Re: [PATCH 1/3] cmake: add knob to disable vcpkg To: Matthew Rogers via GitGitGadget Cc: Git List , Philip Oakley , Sibi Siddharthan , Johannes Schindelin , Danh Doan , Matthew Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Jun 4, 2021 at 1:44 PM Matthew Rogers via GitGitGadget wrote: > When building on windows users have the option to use vcpkg to provide > the dependencies needed to compile. Previously, this was used only when > using the Visual Studio generator which was not ideal because: > > - Not all users who want to use vcpkg use the Visual Studio > generators. > > - Some versions of Visual Studio 2019 moved away from using the > VS 2019 by default, making it impossible for Visual Studio to > configure the project in the likely event that it couldn't find the > dependencies. Is there something missing between "using the" and "VS 2019"? I'm having a hard time trying to understand what this bullet point is saying due to this apparent gap. > - Inexperienced users of CMake are very likely to get tripped up by > the errors caused by a lack of vcpkg, making the above bullet point > both annoying and hard to debug. > > As such, lets make using vcpkg the default on windows. Users who want > to avoid using vcpkg can disable it by passing -DNO_VCPKG=TRUE. s/lets/let's/ > Signed-off-by: Matthew Rogers