From: Eric Sunshine <sunshine@sunshineco.com>
To: Todd Zullinger <tmz@pobox.com>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] t4038-diff-combined: quote paths with whitespace
Date: Sun, 17 Mar 2019 19:11:18 -0400 [thread overview]
Message-ID: <CAPig+cR5uqE+9smKcvZr0oaw2XyqWsYORwAga4WLUX5N+hU4bA@mail.gmail.com> (raw)
In-Reply-To: <20190317230239.10131-1-tmz@pobox.com>
On Sun, Mar 17, 2019 at 7:02 PM Todd Zullinger <tmz@pobox.com> wrote:
> d76ce4f734 ("log,diff-tree: add --combined-all-paths option",
> 2019-02-07) added tests for files containing tabs.
s/files/filenames/
> When the tests are run with bash, the lack of quoting during the file
> setup causes 'ambiguous redirect' errors.
>
> Signed-off-by: Todd Zullinger <tmz@pobox.com>
> ---
>
> I noticed these failures while running in a repo where I happened
> to have TEST_SHELL_PATH=/bin/bash set. I wonder if we should
> have a test matrix which uses bash to catch these sort of things?
Maybe just extending "make test-lint" to catch these would suffice.
next prev parent reply other threads:[~2019-03-17 23:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 23:02 [PATCH] t4038-diff-combined: quote paths with whitespace Todd Zullinger
2019-03-17 23:11 ` Eric Sunshine [this message]
2019-03-18 6:51 ` Junio C Hamano
2019-03-18 15:38 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cR5uqE+9smKcvZr0oaw2XyqWsYORwAga4WLUX5N+hU4bA@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).