From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 3A01C1F453 for ; Thu, 31 Jan 2019 07:21:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726852AbfAaHVJ convert rfc822-to-8bit (ORCPT ); Thu, 31 Jan 2019 02:21:09 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:42292 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725880AbfAaHVI (ORCPT ); Thu, 31 Jan 2019 02:21:08 -0500 Received: by mail-qt1-f196.google.com with SMTP id d19so2412990qtq.9 for ; Wed, 30 Jan 2019 23:21:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+EO4axyVglqb4e0IeQbUEoGxts7dbLXHzKOHPQXW50g=; b=YKwSjsOzLDsDbIyZXID6q8P4UdqyKzwZG4ijcQFguzwpulu8EZBPbkyiPZlbs52A0T Z8ZfugJnKAmncBKxfrfZuH5BW6kqFQoH+IPIGDsIXt/dJ55hxZdmw0J4giR6wQ5bG922 4tPzl2bK1kyLs0EbhZdz0d8coCF/OjlNf7lshNOr94Bs17cUAyM/sOKp20Bl8aM30by+ mUg34iot69WXBHCXWuBkIKlvBUIEYCa2quHn1QAF9QYXVE0aNjxYTCj1ThLGnYW8KBBW CD7l3y0sXHS/QxtCEDU1xIIo3uw+1a+pmKI4lchU9gBEfr8f5cVhQSp2yJ5DGWmPY4vH nf2A== X-Gm-Message-State: AJcUukfXP3rx4t9vq1A1NIHYZrq3PKRtsGMNR43QoYlDH6yrrU20cB6r 0eVeTEwMccDsKILc/7hOXvNjcmWVIOphtm25hSo= X-Google-Smtp-Source: ALg8bN6u3jV6fIqJfH6/XD9YNZ6ysgLzktYD4VlICEwP2nSumVtYzhFWydeAMoJAPIGeC1+wETTYVCqtBglaZpLUnPY= X-Received: by 2002:a0c:9359:: with SMTP id e25mr31506259qve.203.1548919267864; Wed, 30 Jan 2019 23:21:07 -0800 (PST) MIME-Version: 1.0 References: <20190130094831.10420-1-pclouds@gmail.com> <20190130094831.10420-9-pclouds@gmail.com> In-Reply-To: From: Eric Sunshine Date: Thu, 31 Jan 2019 02:20:56 -0500 Message-ID: Subject: Re: [PATCH 08/19] checkout: split part of it to new command switch To: Duy Nguyen Cc: Git List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Jan 31, 2019 at 1:24 AM Eric Sunshine wrote: > On Thu, Jan 31, 2019 at 12:29 AM Duy Nguyen wrote: > > On Thu, Jan 31, 2019 at 7:50 AM Eric Sunshine wrote: > > > On Wed, Jan 30, 2019 at 4:49 AM Nguyễn Thái Ngọc Duy wrote: > > > > +'git switch' [] [--guess] > > > > +'git switch' [] --detach [>] > > > > +'git switch' [] [[-c|-C|--orphan] ] [] > > > > > > What does the third form mean when all optional arguments (that is, > > > _all_ arguments) are omitted? > > > > "git switch" is smart (or too dumb to be clever): > > > > $ git switch > > fatal: nothing to do > > But does it need to be this way? Does it make a good user-experience? > I, personally, find it confusing to see that it can accept no > arguments. An alternative, perhaps more consistent with UX elsewhere: > > $ git switch > fatal: missing branch argument > > or something. Let me clarify by saying that I don't understand why the third form is documented as validly accepting no arguments given that a no-argument invocation is an error. That is, I would expect the third form of the synopsis to say: 'git switch' [] (-c|-C|--orphan) []