From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM, RP_MATCHES_RCVD,T_DKIM_INVALID shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id CB46A20281 for ; Thu, 2 Nov 2017 22:43:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934638AbdKBWnD (ORCPT ); Thu, 2 Nov 2017 18:43:03 -0400 Received: from mail-qk0-f175.google.com ([209.85.220.175]:53542 "EHLO mail-qk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934438AbdKBWnB (ORCPT ); Thu, 2 Nov 2017 18:43:01 -0400 Received: by mail-qk0-f175.google.com with SMTP id y23so1230456qkb.10 for ; Thu, 02 Nov 2017 15:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=M1KelZEEK4vvAl+op7y6JgV5sYShxCKWJKm4KgHCLuc=; b=fnMCedXSa8FHaawhcu/vieVxOFCWPeXIST/NiYmrx8IzDP0h75aCbGPvmb7wPQVpck v0SccD+cMraIeGiKjjat7L0Z5pwtTKLxnqA/G3dAdywn2/5ePUh1kedqXkiyEnZuX3Pq WwyyJys+ieS5i/Tyc0JyNT8g/B46JP9kWY6NE+fvfK2kfZw/cyJRuZeZjMhomBjTmC+K nfwsP/VkohFweSkpSFz9xHy8bWzVCQOLe0R6rVKImAI/3pJqOQ37rdAsnpuOU6J+KwS1 oY3cu/gxR0TdYsw+WEJDnp/Wu9OsMXNpIU/HkCP1R6VAY6vmV32FbP/MgrrEb2OQ9zFk y1wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=M1KelZEEK4vvAl+op7y6JgV5sYShxCKWJKm4KgHCLuc=; b=qpOoymGqh9FkOLvjayO3bw6UEz3WKxfK0WSmvDPGzjCposI+iEV6WB3BIw/ZTKDkB0 SzWP4GExzoDheHTSRg1gxayPJd1IHoIzT9XJvXCon4VTQWdztXBGaL2RAPT/oBzmKVNu nrbeZZIvMHV/nVL8JiTf5hoWO+2DavjAVYqxyB0u2CVBeYzaMK1aOYiQg+389WuARpuE 1+gY40D4SVXZ8OVhD63YtoBvGv4m52h3BaFg7DarhATCN5hTho6yr6tl51EcQYJKjHn0 hcM1wtyQP9gohBppQfvmZK7N42whqBR2IuiCq/dJg7A+1C7i23sDNTaHsWYZyI4OPZJE 012g== X-Gm-Message-State: AJaThX7cL0iwvtazldaY/iAsFf6RBGpXNuOlR3dW+/ZovMPz2ES8M4Am dTXrn9yTpRuEgNjHFh55ccaISOboo7Sbt58pnvM= X-Google-Smtp-Source: ABhQp+SJN0WpURm1yd2KY1OyeTFVH+mZQK5x/xtTfXpTXGT79EVJVJbZjGL2t7+HEZr7FY4k+xXrb4pWd2A3bBvh+nM= X-Received: by 10.55.139.70 with SMTP id n67mr6721406qkd.135.1509662581107; Thu, 02 Nov 2017 15:43:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.146.118 with HTTP; Thu, 2 Nov 2017 15:43:00 -0700 (PDT) In-Reply-To: <20171102212518.1601-5-anarcat@debian.org> References: <20171030025142.19421-1-anarcat@debian.org> <20171102212518.1601-1-anarcat@debian.org> <20171102212518.1601-5-anarcat@debian.org> From: Eric Sunshine Date: Thu, 2 Nov 2017 18:43:00 -0400 X-Google-Sender-Auth: tcD9iyn9vi7HHkSZC4EdFwggAOA Message-ID: Subject: Re: [PATCH v3 4/7] remote-mediawiki: skip virtual namespaces To: =?UTF-8?Q?Antoine_Beaupr=C3=A9?= Cc: Git List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Nov 2, 2017 at 5:25 PM, Antoine Beaupr=C3=A9 w= rote: > Virtual namespaces do not correspond to pages in the database and are > automatically generated by MediaWiki. It makes little sense, > therefore, to fetch pages from those namespaces and the MW API doesn't > support listing those pages. > > According to the documentation, those virtual namespaces are currently > "Special" (-1) and "Media" (-2) but we treat all negative namespaces > as "virtual" as a future-proofing mechanism. > > Reviewed-by: Eric Sunshine It probably would be best to omit this Reviewed-by: since it was not provided explicitly. More importantly, I'm neither a user of nor familiar with MediaWiki or its API, so a Reviewed-by: from me has little or no value. Probably best would be for someone such as Matthieu to give his Reviewed-by: if he so desires. > Signed-off-by: Antoine Beaupr=C3=A9