git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Martin Ågren" <martin.agren@gmail.com>,
	"Git List" <git@vger.kernel.org>,
	"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v2] sequencer: break out of loop explicitly
Date: Wed, 31 Oct 2018 13:28:34 -0400	[thread overview]
Message-ID: <CAPig+cR-W1bQ7wY8k8Zok3hCBxHL8uXmUA2p2Tc9pYYXc7Zr+g@mail.gmail.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1810311553480.4546@tvgsbejvaqbjf.bet>

On Wed, Oct 31, 2018 at 10:54 AM Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> On Tue, 30 Oct 2018, Martin Ågren wrote:
> > Rewrite the loop to a more idiomatic variant which doesn't muck with
> > `len` in the loop body. That should help compilers and human readers
> > figure out what is going on here. But do note that we need to update
> > `len` since it is not only used just after this loop (where we could
> > have used `i` directly), but also later in this function.
> >
> > Signed-off-by: Martin Ågren <martin.agren@gmail.com>
> > ---
>
> ACK. Thanks for cleaning up after me,

Looks good to me, as well. Thanks for working on it.

  reply	other threads:[~2018-10-31 17:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-28 15:31 [PATCH] sequencer: clarify intention to break out of loop Martin Ågren
2018-10-28 19:01 ` Eric Sunshine
2018-10-28 20:37   ` Martin Ågren
2018-10-29  3:43   ` Junio C Hamano
2018-10-30  8:09     ` [PATCH v2] sequencer: break out of loop explicitly Martin Ågren
2018-10-31 14:54       ` Johannes Schindelin
2018-10-31 17:28         ` Eric Sunshine [this message]
2018-10-31 18:41           ` Martin Ågren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cR-W1bQ7wY8k8Zok3hCBxHL8uXmUA2p2Tc9pYYXc7Zr+g@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=martin.agren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).