From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Derrick Stolee" <stolee@gmail.com>,
"Git List" <git@vger.kernel.org>,
"Elijah Newren" <newren@gmail.com>,
"Jean-Noël AVILA" <jn.avila@free.fr>
Subject: Re: ds/sparse-checkout-requires-per-worktree-config (was Re: What's cooking in git.git (Feb 2022, #02; Wed, 9))
Date: Tue, 15 Feb 2022 17:40:35 -0500 [thread overview]
Message-ID: <CAPig+cR+n=LQg5AJQgGQXuYStN90-jExWnE45sS1EXo+O8dQgQ@mail.gmail.com> (raw)
In-Reply-To: <xmqqfsope48k.fsf@gitster.g>
On Fri, Feb 11, 2022 at 11:51 AM Junio C Hamano <gitster@pobox.com> wrote:
> Derrick Stolee <stolee@gmail.com> writes:
> > On 2/9/2022 7:12 PM, Junio C Hamano wrote:
> >> * ds/sparse-checkout-requires-per-worktree-config (2022-02-08) 6 commits
> >> Will merge to 'next'?
> >
> > You and I have had a good discussion about the latest version. I
> > think we've mostly landed on finding ways to improve documentation
> > in other ways (including the patch you submitted), but here are
> > the things that I see as still outstanding:
>
> With the maintainer hat on, I agree that all are good points. From
> a reviewer's point of view, I do not care too deeply about 1 or 2
> myself though.
Agreed.
> > 0. Eric mentioned earlier that he was interested in looking again,
> > but has not signaled that his review is complete.
I have now read through the most recent version and left one or two
minor comments, but probably nothing actionable.
> > 1. You and Eric disagree about the use of "worktree" and "working
> > tree" in the documentation. I could revert the change to these
> > docs from v5 to v6.
I wouldn't go so far as to characterize it as a disagreement. In my
review, I only pointed out that this series was introducing some new
instances of inconsistency which some earlier efforts (started by
Michael Haggerty) had eliminated. As mentioned in [2], I personally
prefer the term "worktree".
[1]: https://lore.kernel.org/git/CAPig+cS-3CxxyPGcy_vkeN_WYTRo1b-ZhJNdPy8ARZSNKkF1Xg@mail.gmail.com/
[2]: https://lore.kernel.org/git/CAPig+cSY7E_XQC1gHzDJxoDGGmgWDmNz9Ys=CwbhLkCt+DQf-A@mail.gmail.com/
> > 2. You mention that the changes in config.c could be split into
> > two (first, create repo_config_set_multivar_gently() and then
> > create repo_config_set_worktree_gently()).
> >
> > 3. Jean-Noël noticed an improvement to reduce work on translators.
> > The diff below could be squashed into patch 5 OR I could submit
> > it as a forward fix.
next prev parent reply other threads:[~2022-02-15 22:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 0:12 What's cooking in git.git (Feb 2022, #02; Wed, 9) Junio C Hamano
2022-02-11 13:40 ` ds/sparse-checkout-requires-per-worktree-config (was Re: What's cooking in git.git (Feb 2022, #02; Wed, 9)) Derrick Stolee
2022-02-11 16:51 ` Junio C Hamano
2022-02-15 22:40 ` Eric Sunshine [this message]
2022-02-16 1:55 ` Junio C Hamano
2022-02-11 21:01 ` What's cooking in git.git (Feb 2022, #02; Wed, 9) Jean-Noël AVILA
2022-02-11 22:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cR+n=LQg5AJQgGQXuYStN90-jExWnE45sS1EXo+O8dQgQ@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jn.avila@free.fr \
--cc=newren@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).