From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id E2AF11F9FC for ; Fri, 17 Dec 2021 06:09:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233180AbhLQGJl convert rfc822-to-8bit (ORCPT ); Fri, 17 Dec 2021 01:09:41 -0500 Received: from mail-pj1-f41.google.com ([209.85.216.41]:38509 "EHLO mail-pj1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230405AbhLQGJl (ORCPT ); Fri, 17 Dec 2021 01:09:41 -0500 Received: by mail-pj1-f41.google.com with SMTP id n15-20020a17090a394f00b001b0f6d6468eso4748704pjf.3 for ; Thu, 16 Dec 2021 22:09:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UOCw6M5pRZTC4h2ZXJiNHL43WcgbKu0XbKvjHIUaFQU=; b=Nl3e9LKWQFA+OaLCsYYuVds0L/nZ7+/Spqfp8YE7UAcqhvbyB3ADyF/bmR2nEfvA6j K4xMeUenY9MuVjt6CtsklPAxFfYqMbS5YnfGanPBKNcfQgpMCVs7rWltLHqiL5fdUQ+7 Pnd2tY3XkzBlIwWSUIuVPZAGlcCbhftPiZvDWQbXndEwoJzaLdyEQlLlRF8n4ENHne/K ppKIGfVEm4MOappSxt4n3s62+Ynwj05baf+7ADuwH/BGTWHL6Exy/QRlhpk45fPSqtPM p/5mUfxF6yhFqHK7V4GZFYlnJz3phEO1Z3Tc9cT3s0qy35V3GI9aSb6yYp5LiEebh0j7 hBVQ== X-Gm-Message-State: AOAM531IIbLvVIaXrTGZubGhHjyh5RCfVc99JAgMXi70NdyFnKIDUwZ0 eL0Dpq0Q8xKp7KrSFWvI7+4cKl0hspVVVI7THz4= X-Google-Smtp-Source: ABdhPJyfQw8NyVCBKino9OTy1JB8zYPNcNXESKzke5gMmpPkUSLCZ8GSO8E3BdnMjfl528U3BAwyg5OV3bfgXHqS/zA= X-Received: by 2002:a17:903:1247:b0:143:b9b9:52a2 with SMTP id u7-20020a170903124700b00143b9b952a2mr1845296plh.35.1639721380921; Thu, 16 Dec 2021 22:09:40 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Eric Sunshine Date: Fri, 17 Dec 2021 01:09:30 -0500 Message-ID: Subject: Re: [PATCH 8/8] Makefiles: add and use wildcard "mkdir -p" template To: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= Cc: Git List , Junio C Hamano , Phillip Wood , Jeff King , Dan Jacques , Eric Wong , Jonathan Nieder , Mike Hommey , =?UTF-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= , Victoria Dye Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Dec 16, 2021 at 11:40 PM Ævar Arnfjörð Bjarmason wrote: > [...] > But as it turns out we can use this neat trick of only doing a "mkdir > -p" if the $(wildcard) macro tells us the path doesn't exist. A re-run > of a performance test similar to thatnoted downthread of [1] in [2] > shows that this is faster, in addition to being less verbose and more > reliable (this uses my "git-hyperfine" thin wrapper for "hyperfine"[3]): s/thatnoted/that noted/ > Signed-off-by: Ævar Arnfjörð Bjarmason > --- > diff --git a/shared.mak b/shared.mak > @@ -90,3 +92,18 @@ ifndef V > +## Is racy, but in a good way; we might redundantly (and safely) > +## "mkdir -p" when running in parallel, but won't need to exhaustively > +## individual rules for "a" -> "prefix" -> "dir" -> "file" if given a > +## "a/prefix/dir/file". This can instead be inserted at the start of > +## the "a/prefix/dir/file" rule. Is there a word missing between "exhaustively" and "individual"?