From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id A67941F953 for ; Wed, 15 Dec 2021 03:15:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235598AbhLODPM (ORCPT ); Tue, 14 Dec 2021 22:15:12 -0500 Received: from mail-pl1-f172.google.com ([209.85.214.172]:37556 "EHLO mail-pl1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231215AbhLODPL (ORCPT ); Tue, 14 Dec 2021 22:15:11 -0500 Received: by mail-pl1-f172.google.com with SMTP id n8so15229893plf.4 for ; Tue, 14 Dec 2021 19:15:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xzCwwU7g+XWOm/FOCymrBBv9uGKhm9S4R7pkIfWyD+o=; b=4bo+kowMyogJRr4vzys3T5KR9vPG7lgnwC9X9FTF4w28/v5fCioVSqH+nA8nN5q20k O7CG6Tv6gSZQ0tPXt++los+Ga/VUr+ss96qRYo9ffKrx9Ho3N0klvC25IKjmLylYNTwQ j8vsr+ULr30SJR62owdr2weyCxXFIakt9u6SSFiSoM2n44ah1BmWCg1i9ZRvqV8Yk802 CPRYv7dBxtIxZX1NmHn3nRhYXw10atMeGPGdAv03QKTu6gy/4qhTmlHtgQdTd5u5GY/v Zxq1woDIParu8txg0uv4/GT3rqZUY/HIwxSt0XhwvxsZgJKzHOj6BJcn5I96F3AopGPR UbOw== X-Gm-Message-State: AOAM532oMlNGYn+vbzQXUEZwkKiiUN98ucNe/XHC9VyR+C94Flxepm0Z ZkLvJH79UWZlCuZ8RPBx8sAVWgeWajlFhDlE+LQ= X-Google-Smtp-Source: ABdhPJywmlWVoMqSYP0cNpZ+Ij3uAIkLZiHy384+uYP3fv9z+knN3+8rXhYucbH/R7KMFwnCMPXhbiySm6HKzCCv3fg= X-Received: by 2002:a17:903:1247:b0:143:b9b9:52a2 with SMTP id u7-20020a170903124700b00143b9b952a2mr9305643plh.35.1639538111283; Tue, 14 Dec 2021 19:15:11 -0800 (PST) MIME-Version: 1.0 References: <20211213063059.19424-1-sunshine@sunshineco.com> In-Reply-To: From: Eric Sunshine Date: Tue, 14 Dec 2021 22:15:00 -0500 Message-ID: Subject: Re: [PATCH 00/15] generalize chainlint self-tests To: Elijah Newren Cc: Git Mailing List , Jeff King , Fabian Stelzer Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Dec 14, 2021 at 7:00 PM Elijah Newren wrote: > On Sun, Dec 12, 2021 at 10:31 PM Eric Sunshine wrote: > > Although the new chainlint implementation has been complete for several > > months, I'm still working out how to organize its patch series. In the > > meantime, _this_ patch series makes it possible for the new linter to > > re-use the existing chainlint self-tests. It does so by cleansing the > > self-test ".test" and ".expect" files of implementation details and > > limitations specific to chainlint.sed. > > I read through the patches in this series, and didn't note any > problems. However, my knowledge of sed is just the basics. Even in a > few cases where regexes were all that were really involved, the > regexes were lengthy enough that my eyes just glazed over. So, my > review is kind of superficial, but the preparatory patches certainly > seem good to me, and the commit messages are well explained, and the > non-sed changes are consistent with the described changes, and the > easier sed stuff looked good. It's clear you put a lot of care into > carefully explaining and dividing up the patches in a nice and logical > manner. Thanks, Elijah, for reading through the series. I wasn't necessarily expecting anyone to read the patches carefully, especially the `sed`-specific changes[*] since it's such an out-of-the-way part of the project, but it's nice to know that the time I put into organizing the series and writing the commit messages wasn't wasted. [*] With the comments stripped out, the entire chainlint.sed script does quite a good job of emulating gobs of line-noise burped up by an old dial-up modem, so it's no surprise your eyes glazed over.