From: Eric Sunshine <email@example.com> To: Jeff King <firstname.lastname@example.org> Cc: "Martin Ågren" <email@example.com>, "Git Mailing List" <firstname.lastname@example.org>, "Taylor Blau" <email@example.com> Subject: Re: [PATCH] list-objects-filter-options: fix function name in BUG Date: Tue, 17 Nov 2020 18:07:07 -0500 [thread overview] Message-ID: <CAPig+cQnA_zqtjOu2OryM57jVMQeo32U3iBYVzxFkPnZ9Zd+cA@mail.gmail.com> (raw) In-Reply-To: <20201117225401.GA642410@coredump.intra.peff.net> On Tue, Nov 17, 2020 at 5:55 PM Jeff King <firstname.lastname@example.org> wrote: > I actually wonder if it is time to drop HAVE_VARIADIC_MACROS completely. > They are in C99, and we have been introducing many other C99-isms. It > would be a minor cleanup to a few bits of code, which perhaps isn't > worth the risk. But I also have a vague memory of not being able to > implement some interfaces because we couldn't count on them. > > Poking around, 3689539127 (add helpers for allocating flex-array > structs, 2016-02-22) points out one such case. I think discussion of > BUG_ON() got blocked by that, too. Looks like we also discussed them in > the big "C99 weather balloon" thread: There was also an idea to use variadic macros to prevent `errno` from being clobbered in a case like this: die_errno(_("blah %s"), foobar()); In which, if foobar() changes `errno`, then die_errno() reports the wrong value. : https://lore.kernel.org/git/CAPig+cQKMxwadf9aGyC5ESa-vxDy9PzrYo+m+JaVQ3S=12PyQQ@mail.gmail.com/
next prev parent reply other threads:[~2020-11-17 23:09 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-14 8:43 Martin Ågren 2020-11-17 2:13 ` Jeff King 2020-11-17 18:02 ` Martin Ågren 2020-11-17 22:54 ` Jeff King 2020-11-17 23:07 ` Eric Sunshine [this message] 2020-11-18 2:08 ` Jeff King 2020-11-18 2:24 ` Jonathan Nieder 2020-11-18 6:22 ` Martin Ågren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAPig+cQnA_zqtjOu2OryM57jVMQeo32U3iBYVzxFkPnZ9Zd+cA@mail.gmail.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] list-objects-filter-options: fix function name in BUG' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).