From: Eric Sunshine <sunshine@sunshineco.com>
To: Jeff King <peff@peff.net>
Cc: Git List <git@vger.kernel.org>,
Thomas Rast <trast@student.ethz.ch>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH 1/4] t5510: start tracking-ref tests from a known state
Date: Tue, 14 May 2013 18:18:07 -0400 [thread overview]
Message-ID: <CAPig+cQk2GCL4z=xo1m86uvKzE2QrP_1ajzkJvDTadxV_dkDuw@mail.gmail.com> (raw)
In-Reply-To: <20130511161400.GA3270@sigill.intra.peff.net>
On Sat, May 11, 2013 at 12:14 PM, Jeff King <peff@peff.net> wrote:
> We have three sequential tests for for whether tracking refs
s/for for/for/
[or]
s/for for/for checking/
> are updated by various fetches and pulls; the first two
> should not update the ref, and the third should. Each test
> depends on the state left by the test before.
>
> This is fragile (a failing early test will confuse later
> tests), and means we cannot add more "should update" tests
> after the third one.
>
> Let's instead save the initial state before these tests, and
> then reset to a known state before running each test.
>
> Signed-off-by: Jeff King <peff@peff.net>
next prev parent reply other threads:[~2013-05-14 22:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 16:13 [RFC/PATCH 0/4] update tracking refs on explicit fetch Jeff King
2013-05-11 16:14 ` [PATCH 1/4] t5510: start tracking-ref tests from a known state Jeff King
2013-05-14 22:18 ` Eric Sunshine [this message]
2013-05-11 16:14 ` [PATCH 2/4] fetch/pull doc: untangle meaning of bare <ref> Jeff King
2013-05-11 16:15 ` [PATCH 3/4] refactor "ref->merge" flag Jeff King
2013-05-11 16:16 ` [PATCH 4/4] fetch: opportunistically update tracking refs Jeff King
2013-05-12 9:15 ` Thomas Rast
2013-05-12 9:41 ` Thomas Rast
2013-05-16 3:37 ` Jeff King
2013-08-06 16:28 ` Junio C Hamano
2013-08-06 21:46 ` Jeff King
2013-08-06 22:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cQk2GCL4z=xo1m86uvKzE2QrP_1ajzkJvDTadxV_dkDuw@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).