From: Eric Sunshine <sunshine@sunshineco.com>
To: Stefan Beller <sbeller@google.com>
Cc: "Ramkumar Ramachandra" <artagnon@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
mina86@mina86.com, mst@kernel.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Jan Viktorin" <viktorin@rehivetech.com>,
zxq_yx_007@163.com
Subject: Re: [PATCH] send-email: error out when relogin delay is missing
Date: Thu, 8 Feb 2018 03:08:11 -0500 [thread overview]
Message-ID: <CAPig+cQejz+1ZWep31hw0pjxUoewRt+-2WATtw6PEusfvhn8EA@mail.gmail.com> (raw)
In-Reply-To: <20180207234359.31493-1-sbeller@google.com>
On Wed, Feb 7, 2018 at 6:43 PM, Stefan Beller <sbeller@google.com> wrote:
> [...]
> Error out for now instead of potentially confusing the user.
> As 5453b83bdf (send-email: --batch-size to work around some SMTP
> server limit, 2017-05-21) lays out, we rather want to not have this
> interface anyway and would rather want to react on the server throttling
> dynamically.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> diff --git a/git-send-email.perl b/git-send-email.perl
> @@ -379,6 +379,9 @@ unless ($rc) {
> +die __("When a batch size is given, the relogin delay must be set\n")
> + if defined $relogin_delay and not defined $batch_size;
This only makes sense is 'batch-size' is specified but not 'relogin'.
If the other way around, then the error is confusing. How about this
instead?
"--batch-size and --relogin must be specified together"
...or something.
next prev parent reply other threads:[~2018-02-08 8:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 12:59 [PATCH v5] send-email: --batch-size to work around some SMTP server limit xiaoqiang zhao
2017-05-22 2:14 ` Junio C Hamano
2017-05-22 3:19 ` Zhaoxiangqiang
2018-02-07 19:45 ` [PATCH] send-email: have default batch size when relogin delay is given Stefan Beller
2018-02-07 19:50 ` Eric Sunshine
2018-02-07 23:43 ` [PATCH] send-email: error out when relogin delay is missing Stefan Beller
2018-02-08 5:45 ` xiaoqiang zhao
2018-02-08 8:08 ` Eric Sunshine [this message]
2018-02-08 18:21 ` Stefan Beller
2018-02-08 22:00 ` Eric Sunshine
2018-02-12 19:44 ` Stefan Beller
2017-05-22 9:26 ` [PATCH v5] send-email: --batch-size to work around some SMTP server limit Ævar Arnfjörð Bjarmason
2017-05-23 7:46 ` Junio C Hamano
2017-05-23 8:30 ` Jan Viktorin
2017-05-23 12:55 ` 赵小强
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cQejz+1ZWep31hw0pjxUoewRt+-2WATtw6PEusfvhn8EA@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=artagnon@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mina86@mina86.com \
--cc=mst@kernel.org \
--cc=pbonzini@redhat.com \
--cc=sbeller@google.com \
--cc=viktorin@rehivetech.com \
--cc=zxq_yx_007@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).