From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id C40C01F626 for ; Tue, 14 Feb 2023 23:31:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232860AbjBNXbA (ORCPT ); Tue, 14 Feb 2023 18:31:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjBNXa7 (ORCPT ); Tue, 14 Feb 2023 18:30:59 -0500 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83E5D2FCF1 for ; Tue, 14 Feb 2023 15:30:58 -0800 (PST) Received: by mail-pg1-f176.google.com with SMTP id 78so11333309pgb.8 for ; Tue, 14 Feb 2023 15:30:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676417458; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uDiwIrxC26pgtL9BIdADgi3V6IfdYIpsXzh4giOFDIA=; b=VzlxMUZh/VdxguDYnvP5Ze5+d+at02lOxZHbLJyzKkIsEaw3GJNjTdpYzI1Rq8Aka5 3CtNnBvOeFy9k3i1/MVPrP9c/8V1t0HZO2tkG8rnagOQ84KQyv+B/odKC/K9J5DE+TQU jdieNSOB6+rUzE/WBb1blaUD52zPICc9DhL7KSYor75owUa8xme3N+klzBg+2czJEcbj nI3hj/XHnZH6D2xg3W7T465nHgmyXdDeQmMgtIp+nJ65Kltod60crnuzQJ/I8pe24kkt 59OIi+LeFn+4IMgEnlvKH/u69Nx+xAHu9hfcyBWFNU9ANREh/xf0GOwHeaH5gXw5GCER qkag== X-Gm-Message-State: AO0yUKUOyv9Fcf03rfeLggybZZQ3pWBfi+vApFgrg5wwpmbEpMy0FGJ6 y1lys26xllSuVA0Y1WM1zTbIxBjMKp4kZDlf2J98/DeA X-Google-Smtp-Source: AK7set+4fcQ0R1rCv5hX4bDW8S6YYur9NLfiA+WuGNUduoiNEsEG71CUw5eBi4DGp6umWbkPdnQ1DxeXVTVymMtamKo= X-Received: by 2002:aa7:972a:0:b0:5a8:c0e0:3b2 with SMTP id k10-20020aa7972a000000b005a8c0e003b2mr798539pfg.45.1676417457861; Tue, 14 Feb 2023 15:30:57 -0800 (PST) MIME-Version: 1.0 References: <20230210080110.32983-1-vinayakdev.sci@gmail.com> In-Reply-To: From: Eric Sunshine Date: Tue, 14 Feb 2023 18:30:46 -0500 Message-ID: Subject: Re: [RFC][GSoC][PATCH] t9160: Change test -(d | f) to test_path_is_* To: Vinayak Dev Cc: git@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Feb 10, 2023 at 6:32 AM Vinayak Dev wrote: > On Fri, 10 Feb 2023 at 16:38, Eric Sunshine wrote: > > On Fri, Feb 10, 2023 at 3:05 AM Vinayak Dev wrote: > > As with the other GSoC patch you submitted[1], this one is also > > missing the "---" line below your sign-off, which tells git-am where > > the commit message ends. As mentioned in [2] you may need to adjust > > your tools or workflow to prevent the "---" line from being stripped. > > I apologise for this mistake again. No need to apologize. Reviewers point out potential problems, not to place blame, but to help you improve the patch. > > The actual changes made by the patch are probably reasonable (though I > > don't have CVS libraries installed presently, so I wasn't able to > > actually test the changes). > > If by testing you mean running the test file to ensure there are no > errors, I did do it thoroughly before sending the patch, > so I can vouch for the changes :) That's very good to hear, and it's the sort of thing you can mention in the patch commentary[1] to help assure reviewers that the patch is sound. [1]: The commentary area of a patch is just _below_ the "---" line which follows your sign-off. You can use the commentary area to supply readers with notes which aren't necessarily relevant to the commit message itself, but which can help reviewers in other ways.