From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <christian.couder@gmail.com>,
Emily Shaffer <emilyshaffer@google.com>,
git <git@vger.kernel.org>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH] doc: improve usage string in MyFirstContribution
Date: Fri, 21 Jun 2019 15:00:05 -0400 [thread overview]
Message-ID: <CAPig+cQJRwfEnsPwY=Cwwy2zPU+=rd+5XJckh7=iEjsb2h1A7g@mail.gmail.com> (raw)
In-Reply-To: <xmqqmuiakgaq.fsf@gitster-ct.c.googlers.com>
On Fri, Jun 21, 2019 at 1:19 PM Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
> > On Fri, Jun 21, 2019 at 6:43 AM Christian Couder
> > <christian.couder@gmail.com> wrote:
> >> On Thu, Jun 20, 2019 at 11:29 PM Emily Shaffer <emilyshaffer@google.com> wrote:
> >> > It doesn't require 1 or more args - you can run it with no args. So it
> >> > might be better suited to state the args as optional:
> >> >
> >> > 'git psuh [arg]...'
> >>
> >> Yeah sure, I will will resend soon with such changes.
> >
> > More correct would be "git psuh [<arg>]".
>
> I think this takes 0 or more, not 0 or 1, so "git psuh [<arg>...]",
> no?
I hadn't read the tutorial, but looking at it now, I see that it
indeed takes zero or more, so "git psuh [<arg>...]" would be best.
prev parent reply other threads:[~2019-06-21 19:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 22:13 [PATCH] doc: improve usage string in MyFirstContribution Christian Couder
2019-06-20 21:29 ` Emily Shaffer
2019-06-21 10:43 ` Christian Couder
2019-06-21 16:37 ` Eric Sunshine
2019-06-21 17:18 ` Junio C Hamano
2019-06-21 19:00 ` Eric Sunshine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cQJRwfEnsPwY=Cwwy2zPU+=rd+5XJckh7=iEjsb2h1A7g@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).