From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id E43391FA12 for ; Tue, 24 Nov 2020 03:02:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726514AbgKXC70 (ORCPT ); Mon, 23 Nov 2020 21:59:26 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:42222 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726256AbgKXC70 (ORCPT ); Mon, 23 Nov 2020 21:59:26 -0500 Received: by mail-ed1-f65.google.com with SMTP id v22so19282637edt.9 for ; Mon, 23 Nov 2020 18:59:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bukSrmeQf7f0PcJDTLRV/Zc6S11atcs8F8e5GZqqKVc=; b=KCl4XR3WrjxGYi9hl6EzdeZcCePG7E+txvw+xbEClVFlDMhwV72/0w3cSUn7FQ8l0Q DTv6kJrH2qS69PjAPa6tiEv07bViVCgX7YUJJIKTlIa9TzkhP4o/VgOpILE6BowD/mDP gWwVUr+U0IfBdjxwwS/VxTIvErO44/BkKwtrDJHZUW/jAvP30K5edHk0NP2CRy3LUF9x Edi3VO8RinjmluTuRm4n7hjdfb821TIikq8zHod8nShfTLuQ46BtP17BPK8qrgqJt6kN iyqobIdVOpkiSWlWI0L0Fdi1kJCpVHZGOZ2ryBa+Iw76DSYf92x/tefIYNVNw/z9AIlS MuqQ== X-Gm-Message-State: AOAM533x4Gbkhl6VCR+lLZjDklbDaG+7Ogjdo7KjLUcc/ZeJda7HoVzg frMofFcA7QeCI1g2zD5NeGdkXoMn9MIgfbXSOJs= X-Google-Smtp-Source: ABdhPJzwo/Vh9ybR1qLx5AP8dqFaSL770/SJKeTEhc+iNSszqY2j/0ddvOPEPmhDGcDCJtITdDmjgtMvYRGFxElvjLI= X-Received: by 2002:a05:6402:1358:: with SMTP id y24mr1973112edw.291.1606186765197; Mon, 23 Nov 2020 18:59:25 -0800 (PST) MIME-Version: 1.0 References: <80762efd-c71b-4485-a2bb-f0577d90ff48@gmail.com> In-Reply-To: <80762efd-c71b-4485-a2bb-f0577d90ff48@gmail.com> From: Eric Sunshine Date: Mon, 23 Nov 2020 21:59:14 -0500 Message-ID: Subject: Re: [PATCH v4 0/4] Maintenance IV: Platform-specific background maintenance To: Derrick Stolee Cc: Derrick Stolee via GitGitGadget , Git List , Derrick Stolee Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Nov 23, 2020 at 9:20 PM Derrick Stolee wrote: > I was giving your 'test-tool getuid' idea a try, and found that _also_ > the $HOME environment variable differs from the format we expect in these > subcommands: > > $HOME: C:\... > argument in subcommand: /c/... Where does this problem crop up exactly? Is the test doing a literal comparison against the value in $HOME? > So, there is another reason why these tests don't work on Windows. I'm > of the opinion that maybe it's not worth _that_ level of cross-platform > testing. > > Unless I'm missing something simple about a $HOME alternative here, this > seems to be more work than the resulting value. Personally, I'm happy > with the benefit you've already provided in allowing Linux to test all > platforms. Indeed, it's not worth investing a lot of additional time into it. And it's certainly not a good reason to hold up the series. Moreover, this is the sort of thing which can be refined/handled later if someone wants to take a shot at it.