git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Cc: Git List <git@vger.kernel.org>, Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH 2/4] t6423: more involved directory rename test
Date: Thu, 15 Oct 2020 16:57:35 -0400	[thread overview]
Message-ID: <CAPig+cQ=WjqfN68GcpaJBC4zjP_q2KnY9k15ErWkFM08TyCVjA@mail.gmail.com> (raw)
In-Reply-To: <c9637d70caed8a265096fa701833eca3ed52d0f3.1602794791.git.gitgitgadget@gmail.com>

On Thu, Oct 15, 2020 at 4:46 PM Elijah Newren via GitGitGadget
<gitgitgadget@gmail.com> wrote:
> Add a new testcase modelled on a real world repository example that
> served multiple purposes:

A couple minor style nits I noticed while quickly running my eye over
the patch...

> +               for i in `test_seq 1 88`; do
> +                       echo content $i >dir/unchanged/file_$i
> +               done &&

'do' on its own line, and prefer $(...) over `...`:

    for i in $(test_seq 1 88)
    do
        echo content $i >dir/unchanged/file_$i
    done &&

(Not necessarily worth a re-roll, though.)

  reply	other threads:[~2020-10-15 20:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 20:46 [PATCH 0/4] Directory rename detection testcases and rules Elijah Newren via GitGitGadget
2020-10-15 20:46 ` [PATCH 1/4] directory-rename-detection.txt: update references to regression tests Elijah Newren via GitGitGadget
2020-10-15 20:46 ` [PATCH 2/4] t6423: more involved directory rename test Elijah Newren via GitGitGadget
2020-10-15 20:57   ` Eric Sunshine [this message]
2020-10-15 20:46 ` [PATCH 3/4] t6423: update directory rename detection tests with new rule Elijah Newren via GitGitGadget
2020-10-15 20:46 ` [PATCH 4/4] t6423: more involved rules for renaming directories into each other Elijah Newren via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPig+cQ=WjqfN68GcpaJBC4zjP_q2KnY9k15ErWkFM08TyCVjA@mail.gmail.com' \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).