From: Eric Sunshine <sunshine@sunshineco.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Cosmin Polifronie <oppturbv@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Running 'git worktree add' in 'pre-commit' hook
Date: Thu, 16 May 2019 07:59:12 -0400 [thread overview]
Message-ID: <CAPig+cQ5T1yj0t1gehXYKN7=rEJ15feOUEJEtAVK565=VwdUrg@mail.gmail.com> (raw)
In-Reply-To: <CACsJy8DnkjuZD-9pbhAsFo16jHKt8U831LLxb3-nCQP5_FOmtA@mail.gmail.com>
On Thu, May 16, 2019 at 7:25 AM Duy Nguyen <pclouds@gmail.com> wrote:
> pre-commit hook sets GIT_INDEX_FILE to this "index.lock" so you have
> the latest index content (which is not the same as from
> $GIT_DIR/index). This variable will interfere with any commands that
> work on a different worktree.
I think that this is not quite accurate. The problem isn't that
git-commit is pointing GIT_INDEX_FILE at a temporary index; that works
fine. The problem is when it is using the normal .git/index file, in
which case the value it assigns to GIT_INDEX_FILE is relative.
For instance, with pre-commit hook:
#!/bin/sh
echo "GIT_INDEX_FILE=$GIT_INDEX_FILE"
git worktree add --detach other
"git-worktree add" with a normal git-commit breaks due to the relative
location specified by GIT_INDEX_FILE:
$ git add file
$ git commit -m foo
GIT_INDEX_FILE=.git/index
Preparing worktree (detached HEAD 0857fef)
fatal: Unable to create '/.../other/.git/index.lock': Not a directory
$
whereas, the "git commit <file>" form succeeds just fine because it
assigns an absolute path for the temporary index:
$ git commit -m foo file
GIT_INDEX_FILE=/.../.git/next-index-23675.lock
Preparing worktree (detached HEAD 0857fef)
HEAD is now at 0857fef first
[master 2fa5413] foo
$
next prev parent reply other threads:[~2019-05-16 11:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 14:52 Running 'git worktree add' in 'pre-commit' hook Cosmin Polifronie
2019-05-15 0:46 ` Bryan Turner
2019-05-15 12:38 ` Cosmin Polifronie
2019-05-16 11:25 ` Duy Nguyen
2019-05-16 11:33 ` Eric Sunshine
2019-05-16 11:39 ` Eric Sunshine
2019-05-16 11:44 ` Duy Nguyen
2019-05-16 12:05 ` Eric Sunshine
2019-05-16 11:41 ` Duy Nguyen
2019-05-16 12:14 ` Eric Sunshine
2019-05-16 12:28 ` Duy Nguyen
2019-05-16 11:59 ` Eric Sunshine [this message]
2019-05-16 22:17 ` Jeff King
2019-05-16 23:16 ` Eric Sunshine
2019-05-17 0:19 ` Jeff King
2019-05-17 1:02 ` Eric Sunshine
2019-05-17 1:19 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cQ5T1yj0t1gehXYKN7=rEJ15feOUEJEtAVK565=VwdUrg@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=oppturbv@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).