From: Eric Sunshine <sunshine@sunshineco.com>
To: Andrei Rybak <rybak.a.v@gmail.com>
Cc: git@vger.kernel.org, Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v1 3/3] t7527: use test_when_finished in 'case insensitive+preserving'
Date: Sat, 14 Jan 2023 04:43:00 -0500 [thread overview]
Message-ID: <CAPig+cQ4k4qTE8JFryvc_DK0CAhwb7XjGhPqzMSTojeSqB4Qpw@mail.gmail.com> (raw)
In-Reply-To: <20230111233242.16870-4-rybak.a.v@gmail.com>
On Wed, Jan 11, 2023 at 7:00 PM Andrei Rybak <rybak.a.v@gmail.com> wrote:
> Most tests in t7527-builtin-fsmonitor.sh that start a daemon, use the
> helper function test_when_finished with stop_daemon_delete_repo.
> Function stop_daemon_delete_repo explicitly stops the daemon. Calling
> it via test_when_finished is needed for tests that don't check daemon's
> automatic shutdown logic [1] and it is needed to avoid daemons being
> left running in case of breakage of the logic of automatic shutdown of
> the daemon.
>
> Unlike these tests, test 'case insensitive+preserving' added in [2] has
> a call to function test_when_finished commented out. It was commented
> out in all versions of the patch [2] during development [3]. This seems
> to not be intentional, because neither commit message in [2], nor the
> comment above the test mention this line being commented out. Compare
> it, for example, to "# unicode_debug=true" which is explicitly described
> by a documentation comment above it.
>
> Uncomment test_when_finished for stop_daemon_delete_repo in test 'case
> insensitive+preserving' to ensure that daemons are not left running in
> cases when automatic shutdown logic of daemon itself is broken.
>
> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
> ---
> diff --git a/t/t7527-builtin-fsmonitor.sh b/t/t7527-builtin-fsmonitor.sh
> @@ -910,7 +910,7 @@ test_expect_success "submodule absorbgitdirs implicitly starts daemon" '
> test_expect_success CASE_INSENSITIVE_FS 'case insensitive+preserving' '
> -# test_when_finished "stop_daemon_delete_repo test_insensitive" &&
> + test_when_finished "stop_daemon_delete_repo test_insensitive" &&
Nice. Thanks for working on this (and the series as a whole) in
response to a very tangential comment of mine[1] when replying to an
unrelated patch of yours.
[1]: https://lore.kernel.org/git/CAPig+cTgUPWxMox_nSka52dML6_GHUUoY4HCtcq7+7J0oEyeNw@mail.gmail.com/
next prev parent reply other threads:[~2023-01-14 9:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 23:32 [PATCH v1 0/3] fixes for commented out code in tests (was "Re: [PATCH] *: fix typos which duplicate a word") Andrei Rybak
2023-01-11 23:32 ` [PATCH v1 1/3] t6003: uncomment test '--max-age=c3, --topo-order' Andrei Rybak
2023-01-11 23:32 ` [PATCH v1 2/3] t6422: drop commented out code Andrei Rybak
2023-01-11 23:32 ` [PATCH v1 3/3] t7527: use test_when_finished in 'case insensitive+preserving' Andrei Rybak
2023-01-14 9:43 ` Eric Sunshine [this message]
2023-01-12 0:45 ` [PATCH v1 0/3] fixes for commented out code in tests (was "Re: [PATCH] *: fix typos which duplicate a word") Tim Schumacher
2023-01-12 1:54 ` Elijah Newren
2023-01-13 4:32 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cQ4k4qTE8JFryvc_DK0CAhwb7XjGhPqzMSTojeSqB4Qpw@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).