From: Eric Sunshine <sunshine@sunshineco.com>
To: Luke Diamand <luke@diamand.org>
Cc: Git List <git@vger.kernel.org>,
"Liu Xuhui (Jackson)" <Xuhui.Liu@amd.com>
Subject: Re: [PATCH 2/2] git-p4: use HEAD~$n to find parent commit for unshelve
Date: Sun, 20 Sep 2020 01:34:51 -0400 [thread overview]
Message-ID: <CAPig+cQ2ccTC+d85A7HCHWeUp1aPgj-LBvbcO_Bv-nVkvTm=RQ@mail.gmail.com> (raw)
In-Reply-To: <20200919085441.7621-3-luke@diamand.org>
On Sat, Sep 19, 2020 at 4:54 AM Luke Diamand <luke@diamand.org> wrote:
> git-p4: use HEAD~$n to find parent commit for unshelve
This commit message repeats what the patch itself says but doesn't
explain why this change is being made or what problem is being solved.
Some explanation to help readers understand the problem would be
welcome.
> Found-by: Liu Xuhui (Jackson) <Xuhui.Liu@amd.com>
I believe this would generally be stated as Reported-by:.
> Signed-off-by: Luke Diamand <luke@diamand.org>
next prev parent reply other threads:[~2020-09-20 5:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 8:54 [PATCH 0/2] git-p4: unshelve uses HEAD^n, not HEAD~n Luke Diamand
2020-09-19 8:54 ` [PATCH 1/2] git-p4 unshelve: adding a commit breaks git-p4 unshelve Luke Diamand
2020-09-19 8:54 ` [PATCH 2/2] git-p4: use HEAD~$n to find parent commit for unshelve Luke Diamand
2020-09-20 5:34 ` Eric Sunshine [this message]
2020-09-20 5:31 ` [PATCH 1/2] git-p4 unshelve: adding a commit breaks git-p4 unshelve Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cQ2ccTC+d85A7HCHWeUp1aPgj-LBvbcO_Bv-nVkvTm=RQ@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=Xuhui.Liu@amd.com \
--cc=git@vger.kernel.org \
--cc=luke@diamand.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).