From: Eric Sunshine <sunshine@sunshineco.com>
To: Hamza Mahfooz <someguy@effective-light.com>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] pretty: colorize pattern matches in commit messages
Date: Sun, 5 Sep 2021 14:01:04 -0400 [thread overview]
Message-ID: <CAPig+cQ2TDjdWd+xUEQ1OQAH8tBQTv=O73MdMOBf8GZ1LFbzDQ@mail.gmail.com> (raw)
In-Reply-To: <20210905120506.635130-1-someguy@effective-light.com>
On Sun, Sep 5, 2021 at 8:05 AM Hamza Mahfooz
<someguy@effective-light.com> wrote:
> [...]
> Teach the pretty-printer code to highlight matches from the
> "--grep=<pattern>", "--author=<pattern>" and "--committer=<pattern>"
> options (to view the last one, you may have to ask for --pretty=fuller).
>
> Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>
> ---
> diff --git a/Documentation/git-log.txt b/Documentation/git-log.txt
> @@ -232,6 +232,14 @@ notes.displayRef::
> or `GIT_NOTES_REF`, to read notes from when showing commit
> messages with the `log` family of commands. See
> linkgit:git-notes[1].
> +
> +color.grep.selected::
> + Determines the non matching text (background) color of selected lines,
> + when `--grep`, `--author` or `--committer` are used.
> +
> +color.grep.matchSelected::
> + Determines the matching text (foreground) color of selected lines, when
> + `--grep`, `--author` or `--committer` are used.
> +
> May be an unabbreviated ref name or a glob and may be specified
> multiple times. A warning will be issued for refs that do not exist,
The paragraph which begins "May be an unabbreviated..." belongs to the
`notes.displayRef` item (which is indicated by the line containing
only a `+` just before the paragraph), so this newly-inserted text
incorrectly divorces the item from the rest of its description. The
two new `color.grep.*` items which this patch adds should be placed
after _all_ the paragraphs connected by `+` lines.
next prev parent reply other threads:[~2021-09-05 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-05 12:05 [PATCH] pretty: colorize pattern matches in commit messages Hamza Mahfooz
2021-09-05 18:01 ` Eric Sunshine [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-01 12:16 Hamza Mahfooz
2021-09-01 17:17 ` Felipe Contreras
2021-09-01 23:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cQ2TDjdWd+xUEQ1OQAH8tBQTv=O73MdMOBf8GZ1LFbzDQ@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=someguy@effective-light.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).