From: Eric Sunshine <email@example.com> To: Junio C Hamano <firstname.lastname@example.org> Cc: Pratik Karki <email@example.com>, Git List <firstname.lastname@example.org> Subject: Re: [GSoC][PATCH v3] test: avoid pipes in git related commands for test Date: Wed, 21 Mar 2018 14:45:06 -0400 [thread overview] Message-ID: <CAPig+cQ1KSL8LreoE7waBzqz2V1N0rwLujDCM82nqTdgF=MC3g@mail.gmail.com> (raw) In-Reply-To: <email@example.com> On Wed, Mar 21, 2018 at 2:11 PM, Junio C Hamano <firstname.lastname@example.org> wrote: > Pratik Karki <email@example.com> writes: >> The changes in patch increased from v1 to v2 because I >> got excited to work in Git codebase and I tried to >> fix the exisiting problems as much as possible. >> Hence, the large number of changes. > > Eric understands why the scope was increased between the two; he > explained why it is not a good idea to increase the scope in the > middle, and I tend to agree with his reasoning. The reason why the > scope was increased does not matter. Thanks, Junio. I had just started writing a review of v3 when your review arrived, and you covered every point I was going to make, thus saved me the effort. I agree with everything in your review. One additional comment, Pratik, is that this patch seems to be based upon a slightly old version of the Git source code, thus does not apply cleanly to present-day 'master'. Before re-rolling, update to the latest Git and rebase your patch atop it. >> - PACK5=$( git rev-list --objects "$LIST" "$LI" "$ST" | \ >> - git pack-objects test-5 ) && >> - PACK6=$( ( >> + git rev-list --objects "$LIST" "$LI" "$ST" >actual && >> + PACK5=$( git pack-objects test-5 <actual ) && >> + PACK6=$(( > > I thought that Eric already pointed out and explained why this > change to PACK6 is wrong in the previous round? I probably should have been more explicit by naming PACK6 directly. Comparing v3 against v2, I see that Pratik probably misunderstood my comment, thinking that I was talking about losing the whitespace inside PACK5=$(...); v2 dropped that whitespace and v3 restored it. Pratik, dropping the unnecessary whitespace inside PACK5=$(...) is fine (no complaint about that), but changing PACK6=$( (...) ) to PACK6=$((...)) is outright incorrect as explained in . : https://public-inbox.org/git/CAPig+cTKkp6kpFcJfVV8W1ejCrCWQH33mHtgFUn+MpMgw5i1pA@mail.gmail.com/
next prev parent reply other threads:[~2018-03-21 18:45 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-13 20:19 [GSoC] [PATCH] test: avoid pipes in git related commands for test suite Pratik Karki 2018-03-14 7:30 ` Eric Sunshine 2018-03-14 9:57 ` Ævar Arnfjörð Bjarmason 2018-03-14 18:22 ` Eric Sunshine 2018-03-15 17:04 ` Junio C Hamano 2018-03-19 17:32 ` [GSoC][PATCH] " Pratik Karki 2018-03-21 11:02 ` Eric Sunshine 2018-03-21 15:23 ` [GSoC][PATCH v3] test: avoid pipes in git related commands for test Pratik Karki 2018-03-21 18:11 ` Junio C Hamano 2018-03-21 18:45 ` Eric Sunshine [this message] 2018-03-21 18:58 ` Eric Sunshine 2018-03-23 15:01 ` [GSoC][PATCH v4] " Pratik Karki 2018-03-25 8:37 ` Eric Sunshine 2018-03-27 17:31 ` [GSoC][PATCH v5] " Pratik Karki 2018-03-30 21:45 ` Eric Sunshine 2018-03-30 22:08 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAPig+cQ1KSL8LreoE7waBzqz2V1N0rwLujDCM82nqTdgF=MC3g@mail.gmail.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [GSoC][PATCH v3] test: avoid pipes in git related commands for test' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).