* [PATCH] fetch: fix extensions.partialclone name in error message
@ 2019-01-13 8:52 Christian Couder
2019-01-13 9:02 ` Eric Sunshine
0 siblings, 1 reply; 2+ messages in thread
From: Christian Couder @ 2019-01-13 8:52 UTC (permalink / raw)
To: git
Cc: Junio C Hamano, Jonathan Tan, Jonathan Nieder, Jeff Hostetler,
Christian Couder
There is "extensions.partialclone" and "core.partialCloneFilter", but
not "core.partialclone". Only "extensions.partialclone" is meant to
contain a remote name.
While at it, let's wrap the relevant code lines to keep them at a
reasonable lenght.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
builtin/fetch.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/builtin/fetch.c b/builtin/fetch.c
index e0140327aa..c0ade48f5d 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -1478,7 +1478,8 @@ static inline void fetch_one_setup_partial(struct remote *remote)
*/
if (strcmp(remote->name, repository_format_partial_clone)) {
if (filter_options.choice)
- die(_("--filter can only be used with the remote configured in core.partialClone"));
+ die(_("--filter can only be used with the remote "
+ "configured in extensions.partialclone"));
return;
}
@@ -1646,7 +1647,8 @@ int cmd_fetch(int argc, const char **argv, const char *prefix)
result = fetch_one(remote, argc, argv, prune_tags_ok);
} else {
if (filter_options.choice)
- die(_("--filter can only be used with the remote configured in core.partialClone"));
+ die(_("--filter can only be used with the remote "
+ "configured in extensions.partialclone"));
/* TODO should this also die if we have a previous partial-clone? */
result = fetch_multiple(&list);
}
--
2.20.1.122.g9a13c7f8ea.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fetch: fix extensions.partialclone name in error message
2019-01-13 8:52 [PATCH] fetch: fix extensions.partialclone name in error message Christian Couder
@ 2019-01-13 9:02 ` Eric Sunshine
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sunshine @ 2019-01-13 9:02 UTC (permalink / raw)
To: Christian Couder
Cc: Git List, Junio C Hamano, Jonathan Tan, Jonathan Nieder,
Jeff Hostetler, Christian Couder
On Sun, Jan 13, 2019 at 3:52 AM Christian Couder
<christian.couder@gmail.com> wrote:
> There is "extensions.partialclone" and "core.partialCloneFilter", but
> not "core.partialclone". Only "extensions.partialclone" is meant to
> contain a remote name.
>
> While at it, let's wrap the relevant code lines to keep them at a
> reasonable lenght.
s/lenght/length/
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-13 9:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-13 8:52 [PATCH] fetch: fix extensions.partialclone name in error message Christian Couder
2019-01-13 9:02 ` Eric Sunshine
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).