git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <stefanbeller@googlemail.com>
Cc: git@vger.kernel.org, jrnieder@gmail.com, trast@student.ethz.ch
Subject: Re: [PATCH 0/2] git diff -q option removal
Date: Wed, 17 Jul 2013 11:06:38 -0700	[thread overview]
Message-ID: <CAPc5daVaOuGD73a=jK7RhOpBnBcUPmL5XnuoXLWYqMs=AoDk0A@mail.gmail.com> (raw)
In-Reply-To: <7vvc496ruf.fsf@alter.siamese.dyndns.org>

On Wed, Jul 17, 2013 at 10:04 AM, Junio C Hamano <gitster@pobox.com> wrote:
> If we wanted to make "-q" follow the spirit of its original addition
> to "show-diff" again, we could internally add a diff-filter when the
> "-q" option is parsed.

Having said all that, I do not mean to advocate to retain "-q". Most
likely nobody uses it, and "-q" is grossly misnamed ("why is it so
special to be "quiet" only for removals?"). As long as we mention its
removal in the release notes (and possibly tell those miniscule
minority that wants to ignore deleted files to use --diff-filter
instead), we should be OK.

Independently, we might want to enhance --diff-filter parser to make
it easier to say "I want everything but D", perhaps use lowercase
letter to subtract from what have been specified so far (or if there
is no uppercase letter, start from "everything"), so that we can say
--diff-filter=d
or something.

  reply	other threads:[~2013-07-17 18:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-14 21:35 [PATCH 1/4] daemon.c:handle: Remove unneeded check for null pointer Stefan Beller
2013-07-14 21:35 ` [PATCH 2/4] commit: Fix a memory leak in determine_author_info Stefan Beller
2013-07-14 21:49   ` Jonathan Nieder
2013-07-14 21:35 ` [PATCH 3/4] diff-no-index: Remove unused variable Stefan Beller
2013-07-14 22:07   ` Jonathan Nieder
2013-07-16 10:28     ` [PATCH 0/2] git diff -q option removal Stefan Beller
2013-07-16 10:28       ` [PATCH 1/2] diff --no-index: remove nonfunctional "-q" handling Stefan Beller
2013-07-16 10:28       ` [PATCH 2/2] diff: Remove -q to stay silent on missing files Stefan Beller
2013-07-17 17:04       ` [PATCH 0/2] git diff -q option removal Junio C Hamano
2013-07-17 18:06         ` Junio C Hamano [this message]
2013-07-17 20:05         ` Stefan Beller
2013-07-18  0:30         ` [PATCH 0/6] Deprecating "diff-files -q" Junio C Hamano
2013-07-18  0:30           ` [PATCH 1/6] diff: pass the whole diff_options to diffcore_apply_filter() Junio C Hamano
2013-07-18  0:30           ` [PATCH 2/6] diff: factor out match_filter() Junio C Hamano
2013-07-18  0:30           ` [PATCH 3/6] diff: preparse --diff-filter string argument Junio C Hamano
2013-07-18  0:30           ` [PATCH 4/6] diff: reject unknown change class given to --diff-filter Junio C Hamano
2013-07-18  0:30           ` [PATCH 5/6] diff: allow lowercase letter to specify what change class to exclude Junio C Hamano
2013-07-18  0:30           ` [PATCH 6/6] diff: deprecate -q option to diff-files Junio C Hamano
2013-07-19  3:20             ` [PATCH 7/6] diff: remove "diff-files -q" at Git 2.0 version boundary Junio C Hamano
2013-07-19  3:31             ` [PATCH 6/6] diff: deprecate -q option to diff-files Jonathan Nieder
2013-07-19  7:24               ` Junio C Hamano
2013-07-19 21:01                 ` Jonathan Nieder
2013-07-14 21:35 ` [PATCH 4/4] diff.c: Do not initialize a variable, which gets reassigned anyway Stefan Beller
2013-07-14 22:18   ` Jonathan Nieder
2013-07-14 21:48 ` [PATCH 1/4] daemon.c:handle: Remove unneeded check for null pointer Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPc5daVaOuGD73a=jK7RhOpBnBcUPmL5XnuoXLWYqMs=AoDk0A@mail.gmail.com' \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=stefanbeller@googlemail.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).