From: Carlo Arenas <carenas@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH 1/1] git-compat-util: add a test balloon for C99 supporty
Date: Mon, 22 Nov 2021 14:22:55 -0800 [thread overview]
Message-ID: <CAPUEspjj4bpnRsr=vpnzuvoHqw9A19fpPcX65oSHZryiyKXxEg@mail.gmail.com> (raw)
In-Reply-To: <xmqqwnkzdepm.fsf@gitster.g>
On Mon, Nov 22, 2021 at 2:10 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> >> But if we were to do so, perhaps we'd want something like what I
> >> gave at https://lore.kernel.org/git/xmqqy25lwa86.fsf@gitster.g/ in
> >> its place to avoid confusing people.
> >
> > That sounds like a good course of action to me.
> >
> > Please note that the MSVC-related adjustment of the `FLEX_ARRAY` block is
> > still needed, I think.
>
> The "something like what I gave ... to avoid confusing people" patch
> is following up on the direction to drop the patch with -std=gnu99
> change. IIRC, your MSVC adjustment was to tweak that patch we were
> discussing of dropping, so even if it is still needed, it won't be
> part of what I was doing.
I think it will still be needed, I have somewhere indeed a bugfix
(which I never got back to clean up enough for sending) to that
section because it was not C89 safe either, which is what dscho is
likely fixing from the point of view of MSVC that doesn't support the
GNU syntax that we use as a fallback eagerly than we should.
FWIW I got the chance to try to build in a long unmaintained debian 6
(AKA squeeze) with gcc 4.4.5 and was greeted by the following edited
message:
error: 'for' loop initial declarations are only allowed in C99 mode
note: use option -std=c99 or -std=gnu99 to compile your code
So I think whatever we do, likely it wouldn't be confusing to whoever
is affected.
Carlo
next prev parent reply other threads:[~2021-11-22 22:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211114211622.1465981-1-sandals@crustytoothpaste.net>
[not found] ` <20211114211622.1465981-2-sandals@crustytoothpaste.net>
2021-11-16 10:30 ` [PATCH 1/1] git-compat-util: add a test balloon for C99 support Johannes Schindelin
2021-11-17 8:29 ` Junio C Hamano
2021-11-22 11:44 ` Johannes Schindelin
2021-11-22 13:05 ` Ævar Arnfjörð Bjarmason
2021-11-22 17:27 ` Junio C Hamano
2021-11-22 17:52 ` Carlo Arenas
2021-11-22 18:58 ` Junio C Hamano
2021-11-22 20:52 ` Junio C Hamano
2021-11-22 22:03 ` [PATCH 1/1] git-compat-util: add a test balloon for C99 supporty Johannes Schindelin
2021-11-22 22:10 ` Junio C Hamano
2021-11-22 22:22 ` Carlo Arenas [this message]
2021-11-23 12:32 ` Johannes Schindelin
2021-11-23 20:17 ` Junio C Hamano
2021-11-24 15:10 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPUEspjj4bpnRsr=vpnzuvoHqw9A19fpPcX65oSHZryiyKXxEg@mail.gmail.com' \
--to=carenas@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).