mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Carlo Arenas <>
To: Johannes Schindelin <>
Cc: "Beat Bolli" <>,, "Ævar Arnfjörð Bjarmason" <>
Subject: Re: [PATCH] grep: print the pcre2_jit_on value
Date: Mon, 29 Jul 2019 01:43:43 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Jul 25, 2019 at 5:50 AM Johannes Schindelin
<> wrote:
> On Wed, 24 Jul 2019, Beat Bolli wrote:
> > Do you mean something like this?
> Yes!

Ideally, though, you want to print those values closing to the match
function (pcre_exec for PCRE1
or pcre2_[jit_]match for PCRE2 as they might change after they are
extracted from the PCRE configuration
with pcre[2]-config()

> > If so, I'll wait a bit until it's clear whether Ævar's series [1] or my
> > patch is going to be applied.
> Sounds fair

FWIW they are both applied (yours all the way to next), but Ævar's
changes now in pu (but likely to be rerolled soon) will most likely
remove your code (as explained on Junio's emails)

> However, my reading of those patches is that they still keep support for
> JIT'ed and non-JIT'ed PCRE2 invocations (preferring the former if
> available, without any UI to change Git's behavior in that respect), so
> I would be surprised if this patch wasn't applicable after Ævar's
> patches.

the PCRE1 changes are significant enough that would break the current
check and might
need a more convoluted check to figure out if JIT was actually used by

more details in the configuration[1]



      reply	other threads:[~2019-07-29  8:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22 18:19 [PATCH] grep: print the pcre2_jit_on value Beat Bolli
2019-07-23 17:34 ` Junio C Hamano
2019-07-23 19:19 ` Johannes Schindelin
2019-07-24 21:25   ` Beat Bolli
2019-07-25  9:13     ` Johannes Schindelin
2019-07-29  8:43       ` Carlo Arenas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).