From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 48C531F47C for ; Fri, 20 Jan 2023 04:48:55 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=F3LsktsC; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229661AbjATEqI (ORCPT ); Thu, 19 Jan 2023 23:46:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230146AbjATEp2 (ORCPT ); Thu, 19 Jan 2023 23:45:28 -0500 Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FD51C6393 for ; Thu, 19 Jan 2023 20:40:40 -0800 (PST) Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-15b9c93848dso5086304fac.1 for ; Thu, 19 Jan 2023 20:40:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=b9uI0wR6ApI0/JXTzj0oZGnZqXncfUQcuDkuAN6qLO0=; b=F3LsktsCNHfv4HU+c8oeN+4HM6s3uk1y8e1qvYqTtAU7CRGDqEv0uj1Jf3L804kJV8 dtDAGlidMW2GFQ4P4l7oPfG0wAt/08e+3bSLVcSRxr4XsqfJNAFWA8GM5W69KKBwcc4r x6TQbBtjyzb5QR2JFcvD6aZ9GUiINKN3npk0pV3gB27IQjSJKstWsdHGU8qfzvcVD+bL MR5JrLJNf/5fQgNdxOUzvSv3zfOJWY5UYKlxFlEOPDsHAF2LWNXGI9a3UCLrh+9Up/NK r3ZYpwAr6Mg5ggeOV2B9Q2Iy2tMBMftflpUJvLOHr53rB3tln3ngR4AI2DSIO/LO+f+w itVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b9uI0wR6ApI0/JXTzj0oZGnZqXncfUQcuDkuAN6qLO0=; b=xKEX1mJtcu3KrjvhmDSSZzH3JYUrwrqHMz3+gXhF4Q6Y8NjztLtLFrjp95ml6pFioy wt6+j7QVvxgITxIs0k346o6CJ1hz8eQspLci5t6l0NR+tqV4hF4l+tJXRRomuLWIEHIw KrW+r5bSSFE93lmCPXk90avLCFpJPTvNh6dNfvlqywzEgBOU2pYC3medZcJ5T4BOOBYQ knoVAMWjfBZdx9X8EsYL26NifhSPGo82RQcFc9+6/IRXeFRzQWmU1UtW5H22pveTKgMg WFyaZCMynne0KxvuVKFe49cnoweVS20I1OJ0ilb3/qhbQ9e4yhhd/zPxh1+ufhY2N0fc lKEA== X-Gm-Message-State: AFqh2kqtmu5NmILkAVqtf2g9XwOLQEBuO/49IrZOSGYI4dTT7fdWbqr2 rNy32KWUdJ5yXdeM23n6SuQtFaUAmBKt/HugsaiPk+Wn3PE= X-Google-Smtp-Source: AMrXdXuWU6JurNod1Rx5x5cvawwDhWiJJehytLnBZa6jzL8etM1BAwmxn5LixsPmPDBlBHejzGIUMNF15YkAeMQITeY= X-Received: by 2002:a05:6870:bc01:b0:15f:33b4:879b with SMTP id oa1-20020a056870bc0100b0015f33b4879bmr914875oab.59.1674189593006; Thu, 19 Jan 2023 20:39:53 -0800 (PST) MIME-Version: 1.0 References: <20230118061527.76218-1-carenas@gmail.com> <20230119055325.1013-1-carenas@gmail.com> In-Reply-To: From: Carlo Arenas Date: Thu, 19 Jan 2023 20:39:41 -0800 Message-ID: Subject: Re: [PATCH v3] checkout/switch: disallow checking out same branch in multiple worktrees To: Junio C Hamano Cc: git@vger.kernel.org, pclouds@gmail.com, Jinwook Jeong , =?UTF-8?B?UnViw6luIEp1c3Rv?= , Eric Sunshine Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org I should have known; the test is affected by the bug Rub=C3=A9n is trying t= o fix in: https://lore.kernel.org/git/eeb0c778-af0a-235c-f009-bca3abafdb15@gmail.co= m/ Where the order that the worktrees are found is not deterministic and so the ignore_current_worktree flag to die_if_checked_out() might trigger incorrectly. Carlo