From: Carlo Arenas <carenas@gmail.com>
To: Adam Dinwoodie <adam@dinwoodie.org>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
git@vger.kernel.org, Fabian Stelzer <fs@gigacodes.de>
Subject: Re: [PATCH] t/lib-git.sh: fix ACL-related permissions failure
Date: Fri, 5 Nov 2021 14:00:32 -0700 [thread overview]
Message-ID: <CAPUEsphasEqT=qfHgO1o4LpzFSWcdhmtTk3o+hYaGNTs35EQKw@mail.gmail.com> (raw)
In-Reply-To: <CA+kUOamwQmK6te66sE+EVLPhwmBFZ+CXC9p=HJ4y0KC0wnkNsQ@mail.gmail.com>
On Fri, Nov 5, 2021 at 1:16 PM Adam Dinwoodie <adam@dinwoodie.org> wrote:
> If OpenSSH were not installed on my system, Git would be compiled
> without this function and the tests would be skipped.
that is correct for the http dependency (because it is a library that
gets linked in), but not for the OpenSSH dependency, which is just
invoking the binary at runtime.
Regardless of what you have in your build environment the code will be
compiled in (and tested or not), and will fail instead at runtime if
OpenSSH is not installed.
Carlo
next prev parent reply other threads:[~2021-11-05 21:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 19:25 [PATCH] t/lib-git.sh: fix ACL-related permissions failure Adam Dinwoodie
2021-11-04 19:49 ` Junio C Hamano
2021-11-04 20:03 ` Junio C Hamano
2021-11-04 22:36 ` Fabian Stelzer
2021-11-05 7:30 ` Junio C Hamano
2021-11-05 11:25 ` Adam Dinwoodie
2021-11-05 12:06 ` Jeff King
2021-11-05 12:13 ` Fabian Stelzer
2021-11-05 18:04 ` Junio C Hamano
2021-11-05 18:49 ` Adam Dinwoodie
2021-11-05 19:11 ` Junio C Hamano
2021-11-05 19:24 ` Adam Dinwoodie
2021-11-05 21:00 ` Carlo Arenas [this message]
2021-11-12 16:01 ` [RFC PATCH] lib-test: show failed prereq was " Fabian Stelzer
2021-11-13 6:10 ` Junio C Hamano
2021-11-13 14:43 ` Fabian Stelzer
2021-11-05 23:53 ` Jeff King
2021-11-05 23:39 ` Jeff King
2021-11-05 18:14 ` Junio C Hamano
2021-11-04 20:09 ` Ramsay Jones
2021-11-05 11:47 ` Adam Dinwoodie
2021-11-05 21:44 ` Ramsay Jones
2021-11-05 19:31 ` [PATCH v2] " Adam Dinwoodie
2021-11-05 21:03 ` Junio C Hamano
2021-11-08 16:40 ` Kerry, Richard
2021-11-08 19:14 ` Junio C Hamano
2021-11-09 17:23 ` Kerry, Richard
2021-11-09 18:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPUEsphasEqT=qfHgO1o4LpzFSWcdhmtTk3o+hYaGNTs35EQKw@mail.gmail.com' \
--to=carenas@gmail.com \
--cc=adam@dinwoodie.org \
--cc=fs@gigacodes.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).