From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 146771F8C6 for ; Fri, 20 Aug 2021 03:19:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235305AbhHTDTt (ORCPT ); Thu, 19 Aug 2021 23:19:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234992AbhHTDTp (ORCPT ); Thu, 19 Aug 2021 23:19:45 -0400 Received: from mail-vs1-xe2b.google.com (mail-vs1-xe2b.google.com [IPv6:2607:f8b0:4864:20::e2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F738C061575 for ; Thu, 19 Aug 2021 20:19:08 -0700 (PDT) Received: by mail-vs1-xe2b.google.com with SMTP id s19so5345445vsl.11 for ; Thu, 19 Aug 2021 20:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VdGTW8uMF3DHeBxkbZzDDBi3EfBbmlpYDKTyZ5Tj4T8=; b=ZBX1XXy+poN4cuyQMg6WY3T/uX3qDH8AkuKimw4idqlkWLPRs3XnVpUCgIRCKTaVyT bG9SqAjaunioCZBeaFWt0nvoJ9SaVZx6Qe5YeuNZkADbQ2wXrx9bVFfvAJ10R/Jqzwg6 f363DENLqDSX/FdWRmKyLf2Khg32v6RYZ0asdoxz2Pj6v+MFrBoGkjGFwIRExsQZ2u6V EbqlDirOQVcmPJE0E1Y3pie6qbKv0qBTdxXh6IfF1+h1KhUcchRQzhxnXuO/oxZ2nXJv heBMBCEXB7seVxkoZRUld3lyNRsVFhdV11blKEckyJqMDZWfRA+GycwQhcMPCAIQAI+g Y09w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VdGTW8uMF3DHeBxkbZzDDBi3EfBbmlpYDKTyZ5Tj4T8=; b=l91TlnqqXJNnDwfqZtcu4pUW08c8ffNgqxOLsgdPPzBvUnUmi6RrGQasZQvRfS4t5l DSZdxcmZdMVBpDZhNM20PO2vPVjvELB5GYBZ+L8ydwzlji6JhSFcoRa7e/x3H/Pql1Zt HICkBs3GXWPSL8DnhoYlh7ZGAj4+kApudFyclz/qnzHFTjYUhwGBwTbDBQiAUyR/DyOp kijbp9GVcvd9BdqDxqF0z4CMdD/ICzhi2DEdBqDxvK/BMb/KtzATjoWE2+8Agw0FCEKi tJJliLLK4UumkRICEeU5t8mWzJCOTpVw92OTo0pnHKQ9sS7BFTOKdWxFNRvGcfVMoH9K uEwg== X-Gm-Message-State: AOAM5326qvsKOMhM8kbug+YhcULAEtu0Hxbfd+aEigWgxiTqvCHu7es3 C0+bxYvMM6Qqmc1aqsvcMJIPWeI++WKYKppKM6Y= X-Google-Smtp-Source: ABdhPJyiTTZ8l49lVTys2NepsrkFiVxVZmIIm6qpqX5FC7h41ye2ThJqc+WH7eVyBOiXCeLtzZA13MiN9WYnhNAROQk= X-Received: by 2002:a05:6102:3594:: with SMTP id h20mr15138757vsu.42.1629429547193; Thu, 19 Aug 2021 20:19:07 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Carlo Arenas Date: Thu, 19 Aug 2021 20:18:53 -0700 Message-ID: Subject: Re: [PATCH 2/2] test-lib-functions: use user's TERM and HOME for 'debug' To: Taylor Blau Cc: Philippe Blain via GitGitGadget , git@vger.kernel.org, =?UTF-8?Q?SZEDER_G=C3=A1bor?= , Elijah Newren , Johannes Schindelin , Jens Lehmann , Philippe Blain Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Aug 19, 2021 at 12:25 PM Taylor Blau wrote: > > On Thu, Aug 19, 2021 at 05:16:35PM +0000, Philippe Blain via GitGitGadget wrote: > > Signed-off-by: Philippe Blain > > --- > > t/test-lib-functions.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh > > index 662cfc4c3e0..86680b1177d 100644 > > --- a/t/test-lib-functions.sh > > +++ b/t/test-lib-functions.sh > > @@ -163,7 +163,7 @@ debug () { > > GIT_DEBUGGER=1 > > ;; > > esac && > > - GIT_DEBUGGER="${GIT_DEBUGGER}" "$@" <&6 >&5 2>&7 > > + TERM="$USER_TERM" HOME="$USER_HOME" GIT_DEBUGGER="${GIT_DEBUGGER}" "$@" <&6 >&5 2>&7 > > I also share some concerns about setting $HOME here (though less than in > test_pause) instead of changing $HOME the needed dot files could be as well linked into the current $HOME. this will of course need extra code and specific knowledge of the debugger that was invoked but will be IMHO safer and accomplish the same objective. Carlo PS. I remember once wondering what GIT_DEBUGGER=1 meant and how it was meant to be used, AFAIK that and the first use case were always broken otherwise, maybe someone who knows and uses this code better could chime in.