From: Carlo Arenas <carenas@gmail.com>
To: Elijah Newren <newren@gmail.com>
Cc: Andrei Rybak <rybak.a.v@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v1 3/3] difftool: add space after full stop in comments
Date: Sat, 2 Oct 2021 13:12:38 -0700 [thread overview]
Message-ID: <CAPUEspgC80_jMJ6Vy8G7YW0v9NXusGCSLzpeBgVZFXpPKJ7a7w@mail.gmail.com> (raw)
In-Reply-To: <CABPp-BGq27kdugX5JivX7uFLmCmHXCsRjqfaA1Q2PXHZ4hCznw@mail.gmail.com>
On Sat, Oct 2, 2021 at 12:38 PM Elijah Newren <newren@gmail.com> wrote:
>
> On Sat, Oct 2, 2021 at 11:49 AM Andrei Rybak <rybak.a.v@gmail.com> wrote:
> >
> > These punctuation typos were found using:
> >
> > git grep -P ' [a-z0-9A-Z-]+[.][A-Z][A-Za-z-]+ '
>
> While Junio has commented that two spaces after the full stop in
> fixed-width source code viewing looks better, and I personally prefer
> that style as well, I don't think these are worth "fixing".
FWIW those are not adding a second space, but adding ANY space between
a "." and beginning of the next sentence.
> you separated this from the other changes, but I'd rather see this
> patch dropped.
While I don't think encouraging this kind of "fixes" might make sense,
the work was already done and the "churn" is very small (only 2 places
out of ~2K), where we have in the codebase: ".<space><space>"
Carlo
next prev parent reply other threads:[~2021-10-02 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 18:44 [PATCH v1 0/3] Typofixes Andrei Rybak
2021-10-02 18:44 ` [PATCH v1 1/3] *: spell Latin abbreviations correctly Andrei Rybak
2021-10-02 19:40 ` Elijah Newren
2021-10-02 20:08 ` Ævar Arnfjörð Bjarmason
2021-10-02 18:44 ` [PATCH v1 2/3] *: fix spelling typos Andrei Rybak
2021-10-02 19:34 ` Elijah Newren
2021-10-02 18:44 ` [PATCH v1 3/3] difftool: add space after full stop in comments Andrei Rybak
2021-10-02 19:36 ` Elijah Newren
2021-10-02 20:12 ` Carlo Arenas [this message]
2021-10-02 23:41 ` Elijah Newren
2021-10-11 15:42 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPUEspgC80_jMJ6Vy8G7YW0v9NXusGCSLzpeBgVZFXpPKJ7a7w@mail.gmail.com \
--to=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).