From: Carlo Arenas <carenas@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
gitmailinglist.bentolor@xoxy.net, git@vger.kernel.org
Subject: Re: Should `@` be really a valid git tag name?
Date: Fri, 17 Sep 2021 17:21:49 -0700 [thread overview]
Message-ID: <CAPUEspg3982Wk7vdO-vFimvyApzYwUtsryZdLt1=sLfrrYngyg@mail.gmail.com> (raw)
In-Reply-To: <xmqqr1dmg5uq.fsf@gitster.g>
On Fri, Sep 17, 2021 at 4:06 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:
>
> > I was leaning towards something like that plus a Documentation update, but
> > noticed that the current behaviour was inconsistent, and the confusion
> > pointed out by Junio seems to indicate it is better if fully restricted.
>
> That is a bad move, as existing repositories may have a ref with
> such a name.
but if they do, it is currently "ambiguous" as you pointed out, and my
patch still allows the use of @ when it is not ambiguous :
$ git branch @/1 @
so Stefano[1] is safe, and anyone that has such a ref is better of
renaming it anyway (which is something I agree we have to add code to
my patch to allow somehow)
> If we tighten anything retroactively, we probably should forgid '@'
> short-hand that stands for HEAD, I would think.
regardless of the merits of that feature, it has been in git since
~v1.8.4, so its removal will also be breaking the user experience
IMHO.
Carlo
[1] https://lore.kernel.org/git/520BC017.7050907@gmail.com/
next prev parent reply other threads:[~2021-09-18 0:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 11:20 Should `@` be really a valid git tag name? gitmailinglist.bentolor
2021-09-17 18:20 ` Carlo Arenas
2021-09-17 20:53 ` Junio C Hamano
2021-09-17 21:47 ` Jeff King
2021-09-17 22:58 ` Carlo Marcelo Arenas Belón
2021-09-17 23:06 ` Junio C Hamano
2021-09-18 0:21 ` Carlo Arenas [this message]
2021-09-18 0:25 ` Junio C Hamano
2021-09-18 4:53 ` Carlo Marcelo Arenas Belón
2021-09-18 13:45 ` Chris Torek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPUEspg3982Wk7vdO-vFimvyApzYwUtsryZdLt1=sLfrrYngyg@mail.gmail.com' \
--to=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitmailinglist.bentolor@xoxy.net \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).