From: Charvi Mendiratta <charvi077@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git <git@vger.kernel.org>,
Christian Couder <christian.couder@gmail.com>,
Phillip Wood <phillip.wood123@gmail.com>
Subject: Re: What's cooking in git.git (Feb 2021, #03; Wed, 17)
Date: Fri, 19 Feb 2021 11:44:30 +0530 [thread overview]
Message-ID: <CAPSFM5caUz-tz3AAAgXeOB26CZ87A0xdG3aHYHTgCC9d8zsbKw@mail.gmail.com> (raw)
In-Reply-To: <xmqq8s7lf9ra.fsf@gitster.g>
On Fri, 19 Feb 2021 at 01:07, Junio C Hamano <gitster@pobox.com> wrote:
>
> Charvi Mendiratta <charvi077@gmail.com> writes:
>
> > On Thu, 18 Feb 2021 at 07:44, Junio C Hamano <gitster@pobox.com> wrote:
> >>
> >> * cm/rebase-i-fixup-amend-reword (2021-02-17) 6 commits
> >> - doc/git-commit: add documentation for fixup[amend|reword] options
> >> - t3437: use --fixup with options to create amend! commit
> >> - t7500: add tests for --fixup[amend|reword] options
> >> - commit: add a reword suboption to --fixup
> >> - commit: add amend suboption to --fixup to create amend! commit
> >> - sequencer: export subject_length()
> >> (this branch uses cm/rebase-i and cm/rebase-i-updates.)
> >>
> >> "git commit --fixup" learns to optionally create "amend!" and
> >> "reword!" commits, that use the log message in "fixup" commit
> >> as the message of the resulting commit.
> >>
> >
> > I would like to put light on the description of the patches. I might have
> > misinterpreted the meaning of _"reword!" commit_ as written above.
> > But I thought to explain that here both additional suboptions i.e
> > `amend` and `reword`
> > of `--fixup` introduced in the patch series creates "amend!" commit only.
>
> Thanks for clarifying. I did mix up in the description.
>
> As the parameter given to the command line option is much more
> end-user facing than which insn it results in the todo list, how
> about explaining the topic like so:
>
> "git commit --fixup=<commit>", which was to tweak the changes
> made to the contents while keeping the original log message
> intact, learned "--fixup=(amend|reword):<commit>", that can be
> used to tweak both the message and the contents, and only the
> message, respectively.
>
Yes, this explains as per the working and sounds good to me.
Thanks and Regards,
Charvi
prev parent reply other threads:[~2021-02-19 6:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 2:11 What's cooking in git.git (Feb 2021, #03; Wed, 17) Junio C Hamano
2021-02-18 3:19 ` Matheus Tavares Bernardino
2021-02-18 18:25 ` Junio C Hamano
2021-02-18 6:44 ` Martin Ågren
2021-02-18 19:31 ` Junio C Hamano
2021-02-18 10:44 ` Charvi Mendiratta
2021-02-18 19:36 ` Junio C Hamano
2021-02-19 6:14 ` Charvi Mendiratta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPSFM5caUz-tz3AAAgXeOB26CZ87A0xdG3aHYHTgCC9d8zsbKw@mail.gmail.com \
--to=charvi077@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).