git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Stefan Xenos <sxenos@google.com>
To: Stefan Beller <sbeller@google.com>
Cc: git <git@vger.kernel.org>, Stefan Xenos <sxenos@gmail.com>
Subject: Re: [PATCH 2/8] evolve: Implement oid_array_contains_nondestructive
Date: Sun, 27 Jan 2019 11:08:42 -0800	[thread overview]
Message-ID: <CAPL8Ziuce2D4iLzkAguzjVvLq8iZXxE_UwxtU7TVKB0D7bG-dA@mail.gmail.com> (raw)
In-Reply-To: <CAGZ79kYiE+VhQw4GMs_VM6kK5yXAQ8An0o4fCVSZ3gr2+rHwiA@mail.gmail.com>

On Tue, Jan 22, 2019 at 11:51 AM Stefan Beller <sbeller@google.com> wrote:
>
> On Mon, Jan 21, 2019 at 2:32 PM <sxenos@google.com> wrote:
> >
>
> > evolve: Implement oid_array_contains_nondestructive
>
> I'd think I would word this
>
>     sha1-array: implement oid_array_contains_nondestructive

Good point. Done.

> as for this patch it is not relevant what we we'll be using it for
> later, but rather that it touches the oidset class?
>
> > From: Stefan Xenos <sxenos@gmail.com>
> >
> > Implement a "contains_nondestructive" function for oid_array that won't
> > sort the array if it is unsorted. This can be used to test containment in
> > the rare situations where the array order matters.
> >
> > The function has intentionally been given a name that is more cumbersome
> > than the "lookup" function, which is what most callers will will want
> > in most situations.
>
> What about naming it oid_array_linear_lookup instead?
> That would still have the common "lookup" in the name and
> the "linear" should be enough to scare away the casual
> user. The non-destructive sounds scary.

It probably shouldn't contain the word "lookup" since the lookup
method returns an index and this new method returns true/false. I
changed it to oid_array_readonly_contains.

> Missing sign off

Thanks!

  reply	other threads:[~2019-01-27 19:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21 22:32 [PATCH 1/8] technical doc: add a design doc for the evolve command sxenos
2019-01-21 22:32 ` [PATCH 2/8] evolve: Implement oid_array_contains_nondestructive sxenos
2019-01-22 19:51   ` Stefan Beller
2019-01-27 19:08     ` Stefan Xenos [this message]
2019-01-21 22:32 ` [PATCH 3/8] evlove: Add the metas namespace to ref-filter sxenos
2019-01-21 22:32 ` [PATCH 4/8] evolve: Add support for parsing metacommits sxenos
2019-01-21 22:32 ` [PATCH 5/8] evolve: Add the change-table structure sxenos
2019-01-21 22:32 ` [PATCH 6/8] evolve: Add support for writing metacommits sxenos
2019-01-21 22:32 ` [PATCH 7/8] evolve: Implement the git change update command sxenos
2019-01-21 22:32 ` [PATCH 8/8] evolve: Add the git change list command sxenos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPL8Ziuce2D4iLzkAguzjVvLq8iZXxE_UwxtU7TVKB0D7bG-dA@mail.gmail.com \
    --to=sxenos@google.com \
    --cc=git@vger.kernel.org \
    --cc=sbeller@google.com \
    --cc=sxenos@gmail.com \
    --subject='Re: [PATCH 2/8] evolve: Implement oid_array_contains_nondestructive' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).