From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id C70681F4B4 for ; Thu, 24 Sep 2020 06:10:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726855AbgIXGKo (ORCPT ); Thu, 24 Sep 2020 02:10:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726683AbgIXGKo (ORCPT ); Thu, 24 Sep 2020 02:10:44 -0400 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B09FC0613CE for ; Wed, 23 Sep 2020 23:10:43 -0700 (PDT) Received: by mail-ed1-x544.google.com with SMTP id a12so2103232eds.13 for ; Wed, 23 Sep 2020 23:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hpl6YzywIzPfzaL2g5MGmngpIgHr7OXRKhMgCN+gOMM=; b=tNwS+VjLSdOSyPc2Yyu0l6unEh1waZnLKFZYlxbdER/YIbD6NRLKwVgKPGurj/u3OW 434LlZxlIxPpQGhu2xhtzPF44IWppYfWt4aFPYMfzBnFsjq2A2vEB77EvtcKC4aJ6+BP reeCq25i/3768uDPo9DXIuD6bXOVWPI/ptFFTGQVWV0m4va/1yshdBj1Hhz2TWnSASQa zZuaVulhJ+cR3l7Q9sxMEbx4AjVeiwxaHa7g78TUV+Y6p/EXPM7VO0+/PTU+/lHjyCsa 4STMiCcJGQzgsjLcOoYYKXN7GFp7E4R279P0UkMxZe3NqKHtVDImYjwCOwigFBm5v1FF cHuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hpl6YzywIzPfzaL2g5MGmngpIgHr7OXRKhMgCN+gOMM=; b=CsfJq17uJiI6dAcdkFd2ppepIM0naSD7nGind4Q0ybEThp2gSbk9hjlUfpAQNQ8Myr Xe4EFjzeWjGirOxsnTnUFdnsBAWosjCgOJUJOaXKZFtahgPK+756nKIOwGEvbd0F2x0V A0G6yrQsAwVyICLnEYzXFWNH8T7F36EPJg6+Q31OWKjAFT0AHDUcv0Tn+biMCGWbZAKW ts/Nc+AhCzPkQqt79405yRxSx5ea4Zp3EiV9I6kQi7xgVN/GZKLAnYWQN3buv3uqIDuU qPgBthWu1YAwbZ6hka1cjkvPCMWc49lqGoGbFLWQStc0OYmHtikYsDr++12JW3TmEmrL hzAA== X-Gm-Message-State: AOAM530BpA+Xa062uyBZ/X177i3vPmzhPPm4EjZHQiUEYiXUdR9csDV5 fBln953ObCoLZBnI97f1AqI3HlSlFTeakwaxX4A= X-Google-Smtp-Source: ABdhPJySIMnj1P/vV8d4EbrE+qf0JrPqdJCf76VPj9QB0K7T+jrRpWM0EhrFLGVL9OPVzcLo5BhSC9rTGx/JiE0aAQo= X-Received: by 2002:aa7:d750:: with SMTP id a16mr3003332eds.362.1600927842199; Wed, 23 Sep 2020 23:10:42 -0700 (PDT) MIME-Version: 1.0 References: <20200923170915.21748-1-chriscool@tuxfamily.org> In-Reply-To: From: Christian Couder Date: Thu, 24 Sep 2020 08:10:31 +0200 Message-ID: Subject: Re: [PATCH] bisect: don't use invalid oid as rev when starting To: Junio C Hamano Cc: Johannes Schindelin , git , Christian Couder , Miriam Rubio Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Sep 23, 2020 at 11:39 PM Junio C Hamano wrote: > > Johannes Schindelin writes: > > > From f673cea53e046774847be918f4023430e56bf6cb Mon Sep 17 00:00:00 2001 > > From: Christian Couder > > Date: Wed, 23 Sep 2020 19:09:15 +0200 > > Subject: [PATCH] bisect: don't use invalid oid as rev when starting > > ... > > diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c > > index 93e855271b9..d11d4c9bbb5 100644 > > --- a/builtin/bisect--helper.c > > +++ b/builtin/bisect--helper.c > > Unfortunately this does not apply to the broken commit or 'master' > or anywhere else, it seems (no such blob as 93e855271b9 found at the > path). > > It is better to make it applicable at least to 'master'. Making it > also apply to 'maint' is optional, I would say, as the bug it fixes > is not so critical. Sorry, I don't know what happened. It seemed to me that my branch was based on master, but maybe I did something wrong. Hopefully the V2 I just sent will be better anyway.