From: Christian Couder <christian.couder@gmail.com>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: git <git@vger.kernel.org>, "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Stefan Beller" <sbeller@google.com>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Jonathan Tan" <jonathantanmy@google.com>,
"Duy Nguyen" <pclouds@gmail.com>,
"Derrick Stolee" <stolee@gmail.com>,
"Carlos Martín Nieto" <cmn@dwim.me>,
"David Turner" <novalis@novalis.org>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Christian Couder" <chriscool@tuxfamily.org>,
"David Turner" <dturner@twopensource.com>
Subject: Re: [PATCH v2] t: make many tests depend less on the refs being files
Date: Fri, 25 May 2018 13:21:05 +0200 [thread overview]
Message-ID: <CAP8UFD3hqQ_F0yafS6v6GWvN7zYomM-=fsZKotP9r-9Xc4qJ+g@mail.gmail.com> (raw)
In-Reply-To: <615f57ad-7591-128a-0c42-660312d34ca2@alum.mit.edu>
On Fri, May 25, 2018 at 10:48 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> On 05/23/2018 07:25 AM, Christian Couder wrote:
>>
>> diff --git a/t/t1401-symbolic-ref.sh b/t/t1401-symbolic-ref.sh
>> index 9e782a8122..a4ebb0b65f 100755
>> --- a/t/t1401-symbolic-ref.sh
>> +++ b/t/t1401-symbolic-ref.sh
>> @@ -65,7 +65,7 @@ reset_to_sane
>> test_expect_success 'symbolic-ref fails to delete real ref' '
>> echo "fatal: Cannot delete refs/heads/foo, not a symbolic ref" >expect &&
>> test_must_fail git symbolic-ref -d refs/heads/foo >actual 2>&1 &&
>> - test_path_is_file .git/refs/heads/foo &&
>> + git rev-parse --verify refs/heads/foo &&
>> test_cmp expect actual
>> '
>> reset_to_sane
>
> Should t1401 be considered a backend-agnostic test, or is it needed to
> ensure that symbolic refs are written correctly in the files backend?
I don't know. And I am ok to go either way. Another possibility would
be to split in two parts.
prev parent reply other threads:[~2018-05-25 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 5:25 [PATCH v2] t: make many tests depend less on the refs being files Christian Couder
2018-05-23 6:08 ` Junio C Hamano
2018-05-25 8:48 ` Michael Haggerty
2018-05-25 8:59 ` Jeff King
2018-05-25 9:05 ` Michael Haggerty
2018-05-25 11:22 ` Christian Couder
2018-05-25 11:21 ` Christian Couder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD3hqQ_F0yafS6v6GWvN7zYomM-=fsZKotP9r-9Xc4qJ+g@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=cmn@dwim.me \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=novalis@novalis.org \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
--cc=stolee@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).