From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [IPv6:2604:1380:45e3:2400::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2F9F61F44D for ; Sat, 27 Apr 2024 12:52:03 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=nDQ4PKS1; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C819A2859DB for ; Sat, 27 Apr 2024 12:52:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9421E4EB37; Sat, 27 Apr 2024 12:51:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nDQ4PKS1" Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D295142047 for ; Sat, 27 Apr 2024 12:51:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714222315; cv=none; b=nNquO/+RIT2+D1eHkNSRAZ6fPpKnCR9laVC04Uc4fn4Aojh7v+7ucIpXJwcDmhgCy4jwvpENphtRV46lup66AljeBAzoQLvx3nlowka10xIQfU9/iqT4H5u96tSHQXVtsKctzw+D1VuqAurKGVxsChJU84AhWKGKTvuuzdnYy14= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714222315; c=relaxed/simple; bh=U4thcNDrZV7Tw1bQVbjkuUv3TPLNkQPffi7H2MGlv7o=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=apU0guscAfUTRweEEbLxo4bznCWStGWEh8eneaXTLFCjuYsA8aYnIExTZCGzgcmJ2otwO+xSbhkpcCgj5W/uKT4MEttE4uUR5zgUAHqbIT7BWxeB/6lX8h2FNuG50/rDMkeD4PBeZdOD6O7MYClkvN+QLV2kSVNiQ4ForBgVR68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nDQ4PKS1; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a519e1b0e2dso418360566b.2 for ; Sat, 27 Apr 2024 05:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714222312; x=1714827112; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aYRuANL37zQ5mjElsa9a38DlotM3a2Cbn+GVpHvsi0U=; b=nDQ4PKS1ucx8XXn9xBN7WBPb8OpQBHAlC1hnUOW8YSfRiqLbfyFC996AchZ3sHqITI b1RBDsPPFsuox5S5hGhAw7kARg1Mz7CaqzpHF3uncjDQqBkBNKMTVqxJhlzDYvn407Ym 6clq4j048TFTRnAp3mzkFUuCrPPJ4qE2Y02OYdHWjpoXXQSJOOmN95dcqs5zumJExeCI 5A8BBGQdkD8AiIWM5bSaLx1wdlrLW5l6Sk5Ygw7rI77pwIqH7/ECPfYX9eKbxf02Psz+ 19ZHTRHMKWVSWSnhLlhOx3EcgWD+0TdcgknrG5cMiUbNh20UHJ+wI07Fn3oA0Bblv5j4 0Hhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714222312; x=1714827112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aYRuANL37zQ5mjElsa9a38DlotM3a2Cbn+GVpHvsi0U=; b=I6kKFB3sFGUHogXUL2/+HaK6ktroMSA02S2OdQN36MRM3O3ti3J4TVaRLg7t9q+mvL KUmEtQzyU5Tsb8zH2RXIGEwwL6jcYdAee5+1idC8OQBoATqbVpkeKM8373EZZRmp2KN6 lATm6zsrDR+3DxpbRRXQrke7Sg+Zqo9yZuPWTVjEkVaN6VLcQfKyOnSHCeWfweSv38Z5 VRG6FUvK3zOlcFFYqHkVpBGvvKNzM4gJbz5YV7YwIiOdrIObTWII3th5CIko1eSkyZzY JMYkxoJp9dB3O1YAHC7A67EOwl8/HB2KXczbFnL6Avtku1AXRcS99Q1934Qhb67VAESn +nrQ== X-Gm-Message-State: AOJu0YznpXBwYqLUYq8iuKMWgY1W5Ytoe8HvzGH0blWdQPpQmtlzsXZM oQ7T98fl9Rxxyrf0fcYokGHjZTghjmq19G4j5+GHjPc/XblPTx7SFOpbm/UWXDrErKZ0SfJol0H OH0rWwbwZWOTyZythFewrt518M8s= X-Google-Smtp-Source: AGHT+IEuaM+edzWuYagHTJzwKMXH7XambTYzqU3d1Zztm8lS0mCpQjJE3pBv5rqAFscpaxnyDioTWkpr8z2+CCVLshs= X-Received: by 2002:a17:906:25d3:b0:a52:ec:a87d with SMTP id n19-20020a17090625d300b00a5200eca87dmr3720054ejb.74.1714222311813; Sat, 27 Apr 2024 05:51:51 -0700 (PDT) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: In-Reply-To: From: Christian Couder Date: Sat, 27 Apr 2024 14:51:39 +0200 Message-ID: Subject: Re: [PATCH v3 00/10] Make trailer_info struct private (plus sequencer cleanup) To: Linus Arver via GitGitGadget Cc: git@vger.kernel.org, Christian Couder , Junio C Hamano , Emily Shaffer , Josh Steadmon , "Randall S. Becker" , Kristoffer Haugsbakk , Linus Arver , Linus Arver Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable (I had sent this email only to Linus too, sorry.) On Fri, Apr 26, 2024 at 2:26=E2=80=AFAM Linus Arver via GitGitGadget wrote: > Linus Arver (10): > Makefile: sort UNIT_TEST_PROGRAMS > trailer: add unit tests for trailer iterator > trailer: teach iterator about non-trailer lines > sequencer: use the trailer iterator > interpret-trailers: access trailer_info with new helpers > trailer: make parse_trailers() return trailer_info pointer > trailer: make trailer_info struct private > trailer: retire trailer_info_get() from API > trailer: document parse_trailers() usage > trailer unit tests: inspect iterator contents I took a look at the whole series and had only a few minor comments on some patches. Thanks!