From: Christian Couder <christian.couder@gmail.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Jeff King <peff@peff.net>,
Sathyajith Bhat <sathya@sathyasays.com>,
git <git@vger.kernel.org>,
Kaartic Sivaraam <kaartic.sivaraam@gmail.com>,
Sangeeta Jain <sangunb09@gmail.com>,
Elijah Newren <newren@gmail.com>
Subject: Re: Segfault in git when using git logs
Date: Tue, 3 Nov 2020 12:21:44 +0100 [thread overview]
Message-ID: <CAP8UFD3SMCBdE8TOP7OKabYyOW4344nNAa=G2hCzxWnN-XjQrA@mail.gmail.com> (raw)
In-Reply-To: <20201103101553.GH24813@szeder.dev>
On Tue, Nov 3, 2020 at 11:19 AM SZEDER Gábor <szeder.dev@gmail.com> wrote:
>
> On Mon, Nov 02, 2020 at 09:43:21AM -0500, Jeff King wrote:
> > but I'm not clear on how "--follow" and "-L" are supposed to interact.
>
> They shouldn't, I would say. Though it would be great if their
> rename-following logic would be unified. In particular, line-level
> log does a better job at rename following in some ways, notably it can
> track multiple files at once, while '--follow' can only handle a
> single file. So I think the rename following logic should be
> extracted from 'line-log.c' and made more generic, and it should be
> used to implement '--follow', removing some restrictions of the
> latter, not to mention removing the duplicated logic.
>
> (This might be a good GSoC project, though some of Linus' remarks in
> 750f7b668f (Finally implement "git log --follow", 2007-06-19) like
> "you did have to know and understand the internal git diff generation
> machinery pretty well, and had to really be able to follow how commit
> generation interacts with generating patches and generating the log"
> and "this patch does seem to be firmly in the core "Linus or Junio"
> territory" are worrying...)
Thanks for the suggestion!
For the Outreachy round starting next December, we have proposed a
project to accelerate rename detection and range-diff based on:
https://github.com/gitgitgadget/git/issues/519
I am not sure how much it is related to this though.
next prev parent reply other threads:[~2020-11-03 11:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 13:59 Segfault in git when using git logs Sathyajith Bhat
2020-11-02 14:43 ` Jeff King
2020-11-02 18:31 ` Junio C Hamano
2020-11-03 10:15 ` SZEDER Gábor
2020-11-03 11:21 ` Christian Couder [this message]
2020-11-03 16:10 ` Elijah Newren
2020-11-03 18:21 ` Jeff King
2020-11-03 18:34 ` Junio C Hamano
2020-11-03 18:57 ` Jeff King
2020-11-03 20:21 ` Junio C Hamano
2020-11-04 13:31 ` Jeff King
2020-11-04 16:26 ` Junio C Hamano
2020-11-04 17:54 ` Re*: " Junio C Hamano
2020-11-04 19:41 ` Jeff King
2020-11-04 20:16 ` Junio C Hamano
2020-11-04 20:35 ` [PATCH] log: diagnose -L used with pathspec as an error Junio C Hamano
2020-11-04 21:03 ` Jeff King
2020-11-03 18:46 ` Segfault in git when using git logs Derrick Stolee
2020-11-03 18:55 ` Sathyajith Bhat
2020-11-03 19:23 ` Jeff King
2020-11-03 20:07 ` Derrick Stolee
2020-11-03 21:04 ` Derrick Stolee
2020-11-04 15:49 ` Sathyajith Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD3SMCBdE8TOP7OKabYyOW4344nNAa=G2hCzxWnN-XjQrA@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=kaartic.sivaraam@gmail.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=sangunb09@gmail.com \
--cc=sathya@sathyasays.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).