From: Christian Couder <christian.couder@gmail.com>
To: Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [GSoC] Convert “git stash” to builtin proposal
Date: Tue, 20 Mar 2018 23:08:37 +0100 [thread overview]
Message-ID: <CAP8UFD3NKCSN8mVDiCUzvor5uZh4nFCAw4T0zgxpvHLf9AWmyA@mail.gmail.com> (raw)
In-Reply-To: <1521576562.2188.10.camel@gmail.com>
Hi,
On Tue, Mar 20, 2018 at 9:09 PM, Paul-Sebastian Ungureanu
<ungureanupaulsebastian@gmail.com> wrote:
>
> * Convert function: this step is basically makes up the goal of this
> project.
Could you explain a bit more how you would convert a function? Or
could you explain for example how you would convert "git stash list"
below?
> * Ensure that no regression occurred: considering that there are plenty
> of tests and that I have a good understanding of the function, this
> should be a trivial task.
>
> * Finally write more tests to ensure best code coverage.
Maybe, as Dscho suggested to another potential GSoC student, it would
be better to write more tests before converting the function.
> # Useful resources
> There has been a lot of progress made in this direction already and I
> believe it will serve of great help. However, from my understanding it
> is not yet mergeable and it requires changes.
>
> https://public-inbox.org/git/20170608005535.13080-1-joel@teichroeb.net/
> T/#m8849c7ce0ad8516cc206dd6910b79591bf9b3acd
Maybe you should Cc the author of this patch series.
Also please notice that the patch series started with adding some tests.
> I am expecting to submit a patch for every command that is converted.
> This way, I have well set milestones and results will be seen as soon
> as possible. Moreover, seeing my contributions getting merged will be a
> huge confidence boost to myself.
> Each “convert” phase of the project below is not only about converting
> from Shell to C, but also ensuring that everything is documented, there
> are enough tests and there are no regressions.
>
> 14th May - 20th May - Convert "git stash list"
For example could you explain a bit more which functions/commands you
would create in which file and how you would call them to convert `git
stash list`
next prev parent reply other threads:[~2018-03-20 22:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 20:09 [GSoC] Convert “git stash” to builtin proposal Paul-Sebastian Ungureanu
2018-03-20 22:08 ` Christian Couder [this message]
2018-03-22 23:15 ` Paul-Sebastian Ungureanu
2018-03-23 17:06 ` Johannes Schindelin
2018-03-25 14:32 ` Paul-Sebastian Ungureanu
2018-03-23 17:11 ` Christian Couder
2018-03-24 19:31 ` Paul-Sebastian Ungureanu
2018-03-25 9:46 ` Christian Couder
2018-03-25 14:38 ` Paul-Sebastian Ungureanu
2018-03-26 22:04 ` Johannes Schindelin
2018-03-27 6:14 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD3NKCSN8mVDiCUzvor5uZh4nFCAw4T0zgxpvHLf9AWmyA@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=ungureanupaulsebastian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).