From: Christian Couder <christian.couder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Todd Zullinger <tmz@pobox.com>,
Junio C Hamano <gitster@pobox.com>, git <git@vger.kernel.org>,
Dominik Mahrer <teddy@teddy.ch>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH] Makefile: check that tcl/tk is installed
Date: Mon, 20 Nov 2017 18:25:36 +0100 [thread overview]
Message-ID: <CAP8UFD3LhR+FRMM--SQVZ_m2-g2w-WkmmFX7aqrp9S5A9vi1ow@mail.gmail.com> (raw)
In-Reply-To: <20171117220210.6xqi26mabbyvxc2m@sigill.intra.peff.net>
On Fri, Nov 17, 2017 at 11:02 PM, Jeff King <peff@peff.net> wrote:
>
> I'm actually tempted to say that we should not be building the tcl parts
> by default. IOW, instead of NO_TCLTK we should have USE_TCLTK. That
> would also require an adjustment by package builders, but it would
> hopefully be a really obvious one. And once the user has told our
> Makefile that they definitely want to build the tcl parts, we'd
> presumably just trust that the tcl path they give us is sane.
>
> But it's possible I'm underestimating how many people actually use the
> tcl scripts. Certainly I don't, and git-gui seems fairly primitive to me
> these days compared to 3rd party tools. But then I don't use any of them
> either. ;)
As I wrote in the version 2 of the patch (yeah I forgot to mark it as
version 2) I agree that removing NO_TCLTK while introducing USE_TCLTK
and not building git-gui and gitk by default is simpler and probably
the right direction for the future, but I think it might be too big a
change for now or until the next major release (Git 3.0.0).
Especially it can cause issues to people who were building and
installing gitk and git-gui because they use it. They might not
realize that USE_TCLTK has been introduced and still think that they
are building and installing the newest versions, when in fact they
would not and keep using old versions.
next prev parent reply other threads:[~2017-11-20 17:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 12:52 [PATCH] Makefile: check that tcl/tk is installed Christian Couder
2017-11-16 1:35 ` Junio C Hamano
2017-11-17 15:35 ` Christian Couder
2017-11-17 17:42 ` Todd Zullinger
2017-11-17 22:02 ` Jeff King
2017-11-20 17:25 ` Christian Couder [this message]
2017-11-20 18:12 ` Christian Couder
-- strict thread matches above, loose matches on Subject: below --
2017-11-20 17:15 Christian Couder
2017-11-20 17:17 ` Christian Couder
2017-11-20 19:19 ` Jonathan Nieder
2017-11-20 23:58 ` Christian Couder
2017-11-26 19:15 ` Jeff King
2017-11-26 20:57 ` Christian Couder
2017-11-27 15:31 ` Jeff King
2017-11-27 1:13 ` Junio C Hamano
2017-11-27 4:31 ` Junio C Hamano
2017-11-27 4:35 ` Jeff King
2017-11-27 5:22 ` Todd Zullinger
2017-11-27 8:24 ` Christian Couder
2017-11-27 15:27 ` Jeff King
2017-11-27 23:42 ` Junio C Hamano
2017-11-28 4:35 ` Junio C Hamano
2017-11-27 9:08 ` Junio C Hamano
2017-11-25 20:46 ` Christian Couder
2017-11-26 3:53 ` Junio C Hamano
2017-11-26 14:00 ` Christian Couder
2017-11-26 17:43 ` Ramsay Jones
2017-11-26 18:34 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD3LhR+FRMM--SQVZ_m2-g2w-WkmmFX7aqrp9S5A9vi1ow@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=teddy@teddy.ch \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).