From: Christian Couder <christian.couder@gmail.com>
To: Matheus Tavares <matheus.bernardino@usp.br>
Cc: git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [GSoC][PATCH 2/2] clone: use dir-iterator to avoid explicit dir traversal
Date: Sat, 16 Feb 2019 07:41:38 +0100 [thread overview]
Message-ID: <CAP8UFD3BvcdfbmYTsAprx0Au_AN2VUbuQd3LA0i9TBz0N4kfYQ@mail.gmail.com> (raw)
In-Reply-To: <20190215154913.18800-3-matheus.bernardino@usp.br>
On Fri, Feb 15, 2019 at 5:39 PM Matheus Tavares
<matheus.bernardino@usp.br> wrote:
>
> Replace usage of opendir/readdir/closedir API to traverse directories
> recursively, at copy_or_link_directory function, by the dir-iterator
> API.
You may want to add that this simplifies the code and avoid recursive
calls of copy_or_link_directory().
Otherwise the patch looks good to me. Thanks.
next prev parent reply other threads:[~2019-02-16 6:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 15:49 [GSoC][PATCH 0/2] clone: convert explicit traversal to Matheus Tavares
2019-02-15 15:49 ` [GSoC][PATCH 1/2] clone: extract function from copy_or_link_directory Matheus Tavares
2019-02-16 6:23 ` Christian Couder
2019-02-18 21:28 ` Matheus Tavares Bernardino
2019-02-15 15:49 ` [GSoC][PATCH 2/2] clone: use dir-iterator to avoid explicit dir traversal Matheus Tavares
2019-02-16 6:41 ` Christian Couder [this message]
2019-02-16 14:38 ` Thomas Gummerer
2019-02-18 21:13 ` Matheus Tavares Bernardino
2019-02-18 23:35 ` Thomas Gummerer
2019-02-19 16:23 ` Matheus Tavares Bernardino
2019-02-19 23:45 ` Thomas Gummerer
2019-02-21 4:46 ` Matheus Tavares Bernardino
2019-02-21 21:25 ` Thomas Gummerer
[not found] ` <CAMy9T_GzgPPMFLrPNbtf4zaYtyCoUDjXQbd2z8JeXFYogvfrVQ@mail.gmail.com>
2019-02-22 0:22 ` Daniel Ferreira (theiostream)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD3BvcdfbmYTsAprx0Au_AN2VUbuQd3LA0i9TBz0N4kfYQ@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matheus.bernardino@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).