git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Christian Couder <christian.couder@gmail.com>
To: Atharva Raykar <raykar.ath@gmail.com>
Cc: Ben Avison <bavison@riscosopen.org>, git <git@vger.kernel.org>,
	Shourya Shukla <shouryashukla.oo@gmail.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Philippe Blain <levraiphilippeblain@gmail.com>
Subject: Re: Bug in git submodule update --remote
Date: Fri, 21 May 2021 20:36:23 +0200	[thread overview]
Message-ID: <CAP8UFD39ShCZRxUN7iHFUSQxO=EL18hhpbNN86SAnASHgxe6sQ@mail.gmail.com> (raw)
In-Reply-To: <FCF5A210-4042-4C1B-87A5-83D916F02FCE@gmail.com>

On Fri, May 21, 2021 at 1:47 PM Atharva Raykar <raykar.ath@gmail.com> wrote:
>
> On 19-May-2021, at 20:11, Ben Avison <bavison@riscosopen.org> wrote:

> > I like that solution. Although, I should note that if the user has set
> > submodule.<name>.remote to something other than 'origin', they will need
> > to ensure that submodule.<name>.branch is also set, or they will still
> > hit the "Unable to find current <remote>/HEAD revision in submodule"
> > error that I initially stumbled on.
> >
> > How about an implementation like the following? I introduced a new "git
> > submodule--helper" command rather than modify "print-default-remote" for
> > a couple of reasons:

First thanks for taking a look at improving git submodule and for
doing so by introducing most of the new code in submodule--helper!

[...]

> Since this would modify the behaviour of the update subcommand, I
> have decided to CC my mentors (Christian and Shourya) who are more
> qualified than me to comment on this proposal.

As commit f0a96e8d's author is Dscho (Johannes Schindelin) and as he
was helped by Philippe Blain, let me CC them too. They might know the
reasons for this behavior better than us.

  reply	other threads:[~2021-05-21 18:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 18:11 Bug in git submodule update --remote Ben Avison
2021-05-19 10:49 ` Atharva Raykar
2021-05-19 14:41   ` Ben Avison
2021-05-21 11:47     ` Atharva Raykar
2021-05-21 18:36       ` Christian Couder [this message]
2021-05-22 19:15     ` Philippe Blain
2021-05-19 11:19 ` Atharva Raykar
2021-05-22 18:02 ` Philippe Blain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP8UFD39ShCZRxUN7iHFUSQxO=EL18hhpbNN86SAnASHgxe6sQ@mail.gmail.com' \
    --to=christian.couder@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=bavison@riscosopen.org \
    --cc=git@vger.kernel.org \
    --cc=levraiphilippeblain@gmail.com \
    --cc=raykar.ath@gmail.com \
    --cc=shouryashukla.oo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).