From: Christian Couder <christian.couder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] test-lib: add ability to cap the runtime of tests
Date: Mon, 5 Jun 2017 07:48:49 +0200 [thread overview]
Message-ID: <CAP8UFD3-=sDQ2PEExLq_A3v5d8w8PJ1aLgBNP725mGHzocuqqQ@mail.gmail.com> (raw)
In-Reply-To: <xmqqefuzurj5.fsf@gitster.mtv.corp.google.com>
On Mon, Jun 5, 2017 at 3:55 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> Realistically I'm going to submit this patch, I'm not going to take
>> the much bigger project of refactoring the entire test suite so that
>> no test runs under N second, and of course any such refactoring can
>> only aim for a fixed instead of dynamic N.
>
> I do not expect any single person to tackle the splitting. I just
> wished that a patch inspired by this patch (or better yet, a new
> version of this patch) made the tail end of "make test" output to
> read like this:
>
> ...
> [18:32:44] t9400-git-cvsserver-server.sh ...... ok 18331 ms
> [18:32:49] t9402-git-cvsserver-refs.sh ........ ok 22902 ms
> [18:32:49] t9200-git-cvsexportcommit.sh ....... ok 25163 ms
> [18:32:51]
> All tests successful.
> Files=785, Tests=16928, 122 wallclock secs ( ...
> Result: PASS
>
> * The following tests took longer than 15 seconds to run. We
> may want to look into splitting them into smaller files.
>
> t3404-rebase-interactive.sh ... 19 secs
> t9001-send-email.sh ........... 22 secs
> t9402-git-cvsserver-refs.sh ... 22 secs
> t9200-git-cvsexportcommit.sh .. 25 secs
>
> when the hidden feature is _not_ used, so that wider set of people
> will be forced to see that some tests take inordinate amount of
> time, and entice at least some of them to look into it.
I wonder if splitting tests would make a good GSoC microproject for next year.
next prev parent reply other threads:[~2017-06-05 5:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 22:13 [PATCH] test-lib: add ability to cap the runtime of tests Ævar Arnfjörð Bjarmason
2017-06-04 0:31 ` Junio C Hamano
2017-06-04 7:29 ` Ævar Arnfjörð Bjarmason
2017-06-05 1:55 ` Junio C Hamano
2017-06-05 5:48 ` Christian Couder [this message]
2017-06-05 18:56 ` Stefan Beller
2017-06-07 10:24 ` Jeff King
2017-06-08 0:59 ` Ramsay Jones
2017-06-05 13:17 ` Lars Schneider
2017-06-05 18:15 ` Ævar Arnfjörð Bjarmason
2017-06-05 19:03 ` Stefan Beller
2017-06-05 20:37 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD3-=sDQ2PEExLq_A3v5d8w8PJ1aLgBNP725mGHzocuqqQ@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).